Skip to content

Fix topic_segment=False skipping memory extraction and storage #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LiGuang0624 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix topic_segment=False skipping memory extraction and storage #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions src/lightmem/memory/lightmem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,22 +295,21 @@ def add_memory(
compressed_messages = msgs
self.logger.info(f"[{call_id}] Pre-compression disabled, using normalized messages")

#topic_segment==false 完全跳过了后续的记忆提取、Embedding 生成和向量数据库存储流程
if not self.config.topic_segment:
# TODO:
self.logger.info(f"[{call_id}] Topic segmentation disabled, returning emitted messages")
return {
"triggered": True,
"cut_index": len(msgs),
"boundaries": [0, len(msgs)],
"emitted_messages": msgs,
"carryover_size": 0,
}

all_segments = self.senmem_buffer_manager.add_messages(compressed_messages, self.segmenter, self.text_embedder)
self.logger.info(f"[{call_id}] Topic segmentation disabled, treating all messages as one segment")
#更严谨，防止compressed_messages为[],导致后面检测不出来
if not compressed_messages:
all_segments = []
else:
all_segments = [compressed_messages]
else:
all_segments = self.senmem_buffer_manager.add_messages(compressed_messages, self.segmenter, self.text_embedder)

if force_segment:
all_segments = self.senmem_buffer_manager.cut_with_segmenter(self.segmenter, self.text_embedder, force_segment)

if force_segment and self.config.topic_segment:
all_segments = self.senmem_buffer_manager.cut_with_segmenter(self.segmenter, self.text_embedder, force_segment)
if not all_segments:
self.logger.debug(f"[{call_id}] No segments generated, returning empty result")
return result # TODO
Expand Down Expand Up @@ -839,4 +838,4 @@ def summarize(
return result
result = build_batch_result(summaries, total_entries, call_id, self.logger)
self.logger.info(f"========== END {call_id} ==========")
return result
return result