fix: monitor stuck on wait when closing #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leovct
requested changes
Nov 25, 2024
Signed-off-by: Ji Hwan <[email protected]>
jhkimqd
force-pushed
the
jihwan/fix-monitor-close-time
branch
from
391ed1f to
2b498a7
Compare
leovct
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix an issue where monitor would get stuck in a wait state before closing. The
time.Sleep(5 * time.Second)was added in #388 to allow the monitor to have enough time to render in cases of infinitely hanging cases before exiting.Removing this does not seem to affect monitor in normal cases, but in cases where there may be higher latencies (perhaps due to an issue in the user's environment, or the RPC itself), it may not give enough time to attempt to connect. However, 5 seconds seemed to be too optimistic, and ideally there shouldn't be this big of a delay for this in a production network.