Skip to content

Validate ABI function name and signatures #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygruening merged 10 commits into from
Feb 5, 2025
Merged

Validate ABI function name and signatures #177

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7c29fe1
Validate ABI function name and signatures so that we throw an argumen…
BellringerQuinn Sep 26, 2024
47b2474
Clearer error messages with examples
BellringerQuinn Sep 26, 2024
e291767
Attempt to recover from improper format
BellringerQuinn Oct 8, 2024
3be2cb3
Merge branch 'master' into Fix/regexValidateAbi
BellringerQuinn Oct 8, 2024
440e897
Merge branch 'master' into Fix/regexValidateAbi
BellringerQuinn Oct 17, 2024
03bc470
Merge branch 'master' into Fix/regexValidateAbi
BellringerQuinn Nov 4, 2024
453d52b
Fix regex
BellringerQuinn Dec 13, 2024
5800eb6
Merge remote-tracking branch 'origin/master' into Fix/regexValidateAbi
BellringerQuinn Jan 9, 2025
3a6679d
Merge remote-tracking branch 'origin/master' into Fix/regexValidateAbi
BellringerQuinn Jan 20, 2025
bd24a04
Merge branch 'master' into Fix/regexValidateAbi
BellringerQuinn Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Assets/SequenceSDK/Ethereum/Tests/ABIRegexTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ public void TestMatchesFunctionName(string input, bool expected)
[TestCase("functionName(a,)", false)]
[TestCase("functionName() ", false)]
[TestCase("function_-123Name()", true)]
[TestCase("function_-123Name(int[])", true)]
[TestCase("functionName(a[],a)", true)]
[TestCase("functionName(a[5],a)", true)]
[TestCase("functionName(a[][],a)", true)]
public void TestMatchesFunctionABI(string input, bool expected)
{
bool result = ABIRegex.MatchesFunctionABI(input);
Expand Down
2 changes: 1 addition & 1 deletion Packages/Sequence-Unity/Sequence/SequenceSDK/Ethereum/Contract/ABIRegex.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ public static class ABIRegex
{

public const string FunctionNameRegex = @"^[A-Z|a-z|_,-|0-9]+$";
public const string FunctionABIRegex = @"^[A-Z|a-z|_,-|0-9]+\(([A-Z|a-z|0-9]+(, *[A-Z|a-z|0-9]+)*)?\)$";
public const string FunctionABIRegex = @"^[A-Z|a-z|_,-|0-9]+\(([A-Za-z0-9\[\]]+(, *[A-Za-z0-9\[\]]+)*)?\)$";

public static bool MatchesFunctionName(string input)
{
Expand Down
2 changes: 1 addition & 1 deletion Packages/Sequence-Unity/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "xyz.0xsequence.waas-unity",
"version": "3.17.0",
"version": "3.17.1",
"displayName": "Sequence Embedded Wallet SDK",
"description": "A Unity SDK for the Sequence WaaS API",
"unity": "2021.3",
Expand Down
Loading