Validate ABI function name and signatures #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t exception and make it easier to diagnose a common issue where users were providing an ABI in the wrong format
Member
|
nice work.. I think even better.. just port the code https://github.com/0xsequence/ethkit/blob/master/ethcoder/events_parser.go#L38 to C# .. as you will see, its just string manipulation. I propose name the function, then, you can handle any input and it will just work, it wont error for users :) its 350 LOC |
Merged
caballoninja
previously approved these changes
Jan 28, 2025
andygruening
approved these changes
Feb 5, 2025
Contributor
andygruening
left a comment
andygruening
left a comment
There was a problem hiding this comment.
Looks good to me, works fine for the "redeem" function ABI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that we throw an argument exception and make it easier to diagnose a common issue where users were providing an ABI in the wrong format