GL_Data_Reporting-398: Add SP verification report#12670
GL_Data_Reporting-398: Add SP verification report#12670shilenpatel1 wants to merge 2 commits intomainfrom
Conversation
shilenpatel1
force-pushed
the
252_SP_Verification_report
branch
from
b1eb586 to
fba2bfa
Compare
shilenpatel1
changed the title
shilenpatel1
requested review from
ambuj-neupane-tts,
astrogeco and
koseni123
|
@astrogeco I thought to do that, but as of now if we will add that to job config, once deployed it will start sending an email. Do we want that? Also, sp_verification_report_configs is not yet available in any environment, once this will merged and deployed I can see that in secrets and edit that right |
yes, we want it to send internal emails only |
|
Before the PR deploys we should add the new parameters in the secrets manager |
@astrogeco I have added in dev and int |
|
|
@shilenpatel1 Did you test for mutiple server providers? Please include full screenshot of report showing the overview section where the SP is shown. |
@koseni123 I tested it with multiple service p[roviders also, it worked! I put the screenshots in ticker. Also, there is full screenshot of the report. |
|
@astrogeco I have made all requested changes, can you please review this PR? |
shilenpatel1
force-pushed
the
252_SP_Verification_report
branch
3 times, most recently
from
e2d94c1 to
eb63aca
Compare
|
Left some comments in #12742 |
shilenpatel1
changed the title
shilenpatel1
force-pushed
the
252_SP_Verification_report
branch
from
625a9ea to
6f8ccaf
Compare
* changelog: Internal, Reporting, genericize IRSFraudMetricReport see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/369
|
Closing this PR because these changes will be added as part of https://github.com/18F/identity-idp/pull/12762/changes |
|
Closing this PR because these changes will be added as part of https://github.com/18F/identity-idp/pull/12762/changes |
* Add Monthly SP Verification Report * changelog: Internal, Reporting, Add Monthly SP Verification Report see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/373 * Fix ReportMailer in Monthly SP Verification Report * changelog: Internal, Reporting, Add Monthly SP Verification Report see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/373 * Make change in IRS Report file to see diff * changelog: Internal, Reporting, Add Monthly SP Verification Report see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/373 * Add SP Report file, to pass specs * changelog: Internal, Reporting, Add Monthly SP Verification Report see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/373 * dummy to trigger * changelog: Internal, Reporting, Add Monthly SP Verification Report see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/373 * Remove sp files * Update class names * Rename job classes in config * algin spec reference * Change SP class names back to IRS for review * Add 'plain' original verification report * Add refactor for 'plain' verification report See ##12670 * Add entries in report mailer preview * Linter fix * add report mailer preview for sp_verification * changelog: Internal, Reporting, Add report mailer preview see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/373 --------- Co-authored-by: gerardo.cruz-ortiz <59618057+astrogeco@users.noreply.github.com>
3 participants
🎫 Ticket
GL_Data_Reporting-398
Link to the relevant ticket:
GL_Data_Reporting-398
🛠 Summary of changes
Write a brief description of what you changed.
--> Implement SPVerification report job that expands the capability of sending the report to differnet agency, not just the IRS.
--> Implement SPVerificationReport at lib/reporting/sp_verification_report.rb, that generates the actual report
--> Added sp_verification_report_configs in identity_config and set the default value for that.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
Testing with giving Single Service providers
Send email to internal:
Send email to both:
Testing with giving multiple Service providers
Here, is the rails console local testing:
Here is the report output in browser, I got 2 reports one for each service provider:
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Testing inside Local Rails Console:
Before:
After: