GL_398: Commit to see diff with orginal IRS verification report#12742
GL_398: Commit to see diff with orginal IRS verification report#12742shilenpatel1 wants to merge 4 commits intomainfrom
Conversation
|
|
||
| def reports | ||
| @reports ||= irs_verification_report.as_emailable_reports | ||
| def reports(issuers, agency_abbreviation) |
There was a problem hiding this comment.
why are we getting rid of memoization here?
There was a problem hiding this comment.
That was causing an issue. When I was testing it for multiple configs, it was using first created one for the second config as well, and becasue of that both reports were showing the same issuers in the report
There was a problem hiding this comment.
that makes sense, there might be a smarter way to do it without completely getting rid of the memoization. Although I wonder if the performance savings is worth it
|
Reference the other PR here please |
|
|
||
| def reports | ||
| @reports ||= irs_verification_report.as_emailable_reports | ||
| def reports(issuers, agency_abbreviation) |
There was a problem hiding this comment.
that makes sense, there might be a smarter way to do it without completely getting rid of the memoization. Although I wonder if the performance savings is worth it
shilenpatel1
changed the title
|
I think we can close this PR right? |
2 participants
No description provided.