Skip to content

Comments

fix: Line break truncated characters in English(#3103)#3109

Merged
wangdan-fit2cloud merged 1 commit intomainfrom
pr@main/english-line-break
May 19, 2025
Merged

fix: Line break truncated characters in English(#3103)#3109
wangdan-fit2cloud merged 1 commit intomainfrom
pr@main/english-line-break

Conversation

@wangdan-fit2cloud
Copy link
Contributor

What this PR does / why we need it?

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@wangdan-fit2cloud wangdan-fit2cloud merged commit ceccf9f into main May 19, 2025
4 checks passed
@wangdan-fit2cloud wangdan-fit2cloud deleted the pr@main/english-line-break branch May 19, 2025 08:38
word-break: break-word;
}
.md-editor-admonition {
margin: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! The code looks mostly clean and well-formatted. Here are a few quick notes for optimization:

  1. Word Break: Ensure that the word-break property is necessary if it resolves any specific layout issues. It may not be needed depending on your content.

  2. Importance of !important Rule: While using !important can sometimes help with specificity, it's generally recommended to avoid its use unless absolutely necessary because it overrides other styles elsewhere in the stylesheet or HTML.

  3. Comments: Consider adding comments explaining areas where !important is used, especially if this rule might affect accessibility or maintainability later.

If you have more questions about the code or need further assistance, feel free to ask!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants