Skip to content

fix: Line break truncated characters in English(#3103) #3109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangdan-fit2cloud merged 1 commit into from
May 19, 2025
Merged

fix: Line break truncated characters in English(#3103) #3109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/src/styles/md-editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
}
p {
padding: 0 !important;
word-break: break-word;
}
.md-editor-admonition {
margin: 0;
Copy link
Contributor

@shaohuzhang1 shaohuzhang1 May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! The code looks mostly clean and well-formatted. Here are a few quick notes for optimization:

  1. Word Break: Ensure that the word-break property is necessary if it resolves any specific layout issues. It may not be needed depending on your content.

  2. Importance of !important Rule: While using !important can sometimes help with specificity, it's generally recommended to avoid its use unless absolutely necessary because it overrides other styles elsewhere in the stylesheet or HTML.

  3. Comments: Consider adding comments explaining areas where !important is used, especially if this rule might affect accessibility or maintainability later.

If you have more questions about the code or need further assistance, feel free to ask!

Expand Down