Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Nov 11, 2024

This PR contains the following updates:

Package Update Change
metabase/metabase patch v0.51.2 -> v0.51.3

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 11, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

image: metabase/metabase:v0.51.3
container_name: ${CONTAINER_NAME}
ports:
- ${PANEL_APP_PORT_HTTP}:3000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码没有明显的不合规或问题,但是可以进行一些小的优化。

  1. 需要使用引号避免拼写错误。
  2. 双斜杠不能用于路径分隔符(-不是可识别字符)。
  3. 保持服务名统一。如果可能的话,将所有的服务名称更改为Metabase,并且在容器名字中包含"metabase"以保持一致性.

示例:services:[
"metabase",
]

这个是简单的例子。具体的命名规则最好参考对应的社区文档。

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wanghe-fit2cloud wanghe-fit2cloud merged commit f9463b8 into dev Nov 12, 2024
@wanghe-fit2cloud wanghe-fit2cloud deleted the renovate/metabase-metabase-0.x branch November 12, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants