Skip to content

chore(deps): update metabase/metabase docker tag to v0.51.3 #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghe-fit2cloud merged 2 commits into from
Nov 12, 2024
Merged

chore(deps): update metabase/metabase docker tag to v0.51.3 #2480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
000ae45
chore(deps): update metabase/metabase docker tag to v0.51.3
renovate[bot] Nov 11, 2024
31a4e44
Update app version [skip ci]
Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 apps/metabase/0.51.2/data.yml → apps/metabase/0.51.3/data.yml
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion apps/metabase/0.51.2/docker-compose.yml → apps/metabase/0.51.3/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
metabase:
image: metabase/metabase:v0.51.2
image: metabase/metabase:v0.51.3
container_name: ${CONTAINER_NAME}
ports:
- ${PANEL_APP_PORT_HTTP}:3000
Copy link

@fit2cloudrd fit2cloudrd Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码没有明显的不合规或问题，但是可以进行一些小的优化。

  1. 需要使用引号避免拼写错误。
  2. 双斜杠不能用于路径分隔符(-不是可识别字符)。
  3. 保持服务名统一。如果可能的话，将所有的服务名称更改为Metabase，并且在容器名字中包含"metabase"以保持一致性.

示例：services:[
"metabase",
]

这个是简单的例子。具体的命名规则最好参考对应的社区文档。

Expand Down