Bugfix parsing of features for lcs traces

[shermanjlim]

Minor bug fixes for using features in lcs traces.

[gemini-code-assist]

Summary of Changes

Hello @shermanjlim, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses minor but critical bugs related to the parsing and reading of features within the libCacheSim library. It rectifies an issue in the command-line interface utility that prevented correct interpretation of feature column specifications and streamlines the process of extracting feature data from LCS trace records, ensuring data integrity and correct simulation behavior.

Highlights

• CLI Feature Parsing Fix: Corrected a bug in cli_reader_utils.c where the feature-cols parameter was not being parsed correctly due to an incorrect delimiter being used in the strsep function, ensuring multiple feature columns separated by | are now handled as intended.
• LCS Trace Feature Reading Simplification: Simplified the logic for reading features from lcs_req_v3_t records in lcs.c by removing redundant and potentially incorrect pointer arithmetic, making the code cleaner and more robust.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces two bug fixes related to parsing features for LCS traces. The first change in cli_reader_utils.c corrects the delimiter used for parsing feature columns. The second change in lcs.c fixes incorrect pointer arithmetic when reading features. Both fixes are correct and address the intended issues. I have included one high-severity comment pointing out a memory leak in cli_reader_utils.c that is closely related to the modified code.