Skip to content

Bugfix parsing of features for lcs traces #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1a1a11a merged 2 commits into from
Nov 5, 2025
Merged

Bugfix parsing of features for lcs traces #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2780e32
bugfix feature-cols parsing
Nov 3, 2025
24094f6
bugfix pointer arithmetic for parsing lcs features
Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions libCacheSim/bin/cli_reader_utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,12 @@ void parse_reader_params(const char *reader_params_str,
} else if (strcasecmp(key, "feature-cols") == 0) {
// feature-cols=1|2|3
char *feature_str = strdup(value);
char *feature = strsep(&feature_str, "|");
char *feature;
int i = 0;
while (feature != NULL) {
while ((feature = strsep(&feature_str, "|")) != NULL) {
params->feature_fields[i] = (int)strtol(feature, &end, 0);
_check_parsed_result(end, params->feature_fields[i]);
i++;
feature = strsep(&feature_str, ",");
}
params->n_feature_fields = i;
} else if (strcasecmp(key, "ttl-col") == 0) {
Expand Down
2 changes: 1 addition & 1 deletion libCacheSim/traceReader/customizedReader/lcs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ int lcs_read_one_req(reader_t *reader, request_t *req) {
int32_t *features = (int32_t *)(record + sizeof(lcs_req_v3_t));
req->n_features = n_features;
for (int i = 0; i < n_features; i++) {
req->features[i] = *(int32_t *)(features + i * sizeof(int32_t));
req->features[i] = features[i];
}
} else {
ERROR("invalid lcs version %ld\n", (unsigned long)reader->lcs_ver);
Expand Down
Loading