Fix unescaped font-family quotes in SVG output#35
Closed
smitbarmase wants to merge 1 commit into1jehuang:masterfrom
Closed
Fix unescaped font-family quotes in SVG output#35smitbarmase wants to merge 1 commit into1jehuang:masterfrom
smitbarmase wants to merge 1 commit into1jehuang:masterfrom
Conversation
smitbarmase
added a commit
to zed-industries/zed
that referenced
this pull request
Feb 13, 2026
Closes #10696 Adds support for rendering Mermaid diagrams in the markdown preview using [mermaid-rs-renderer](https://github.com/1jehuang/mermaid-rs-renderer) (with [a patch](1jehuang/mermaid-rs-renderer#35)). - Renders mermaid diagrams on background task - Shows the previously cached image while re-computing - Supports a scale parameter i.e. default 100 - Falls back to raw mermaid source code when render fails <img width="1512" height="897" alt="image" src="https://github.com/user-attachments/assets/9157625d-bb62-402f-8a8b-517f28d43f95" /> Release Notes: - Added mermaid diagram rendering support to the markdown preview panel. --------- Co-authored-by: oscarvarto <contact@oscarvarto.mx> Co-authored-by: oscarvarto <oscarvarto@users.noreply.github.com> Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
|
Was just about to add a PR to fix this and then noticed a fix was already raised lol Please merge this in!! This error is trivial to recreate |
Author
|
Closing this in favor of #38, as it handles issue more correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Font families containing quotes (e.g. "Segoe UI") were interpolated directly into SVG font-family attributes without XML escaping, producing invalid XML. Handles it by adding
escape_xml().