THREESCALE-12434: Migrate from protected attributes to strong parameters - Part 1#4248
Open
THREESCALE-12434: Migrate from protected attributes to strong parameters - Part 1#4248
Conversation
jlledom
previously approved these changes
Mar 11, 2026
Contributor
jlledom
left a comment
jlledom
left a comment
There was a problem hiding this comment.
If tests pass, approved 👍
Contributor
|
Still a lot of references to |
mayorova
force-pushed
the
strong-params-part1
branch
from
ead0bc4 to
29161ea
Compare
mayorova
changed the title
mayorova
force-pushed
the
strong-params-part1
branch
2 times, most recently
from
ae221f6 to
0b8ead4
Compare
mayorova
force-pushed
the
strong-params-part1
branch
from
0b8ead4 to
6c69623
Compare
❌ 1 blocking issue (1 total)
|
jlledom
force-pushed
the
remove-inherited_resources
branch
from
6bd96d4 to
f3227e4
Compare
mayorova
force-pushed
the
strong-params-part1
branch
2 times, most recently
from
bf3524b to
a08b299
Compare
- AuthenticationProvider::RedhatCustomerPortal - AuthenticationProvider::ServiceDiscoveryProvider - CMS::GroupSection - CMS::Permission - ApplicationKey - BackendEvent - LineItem - Onboarding - Partner - Post - ReferrerFilter
- Switches - SystemName - Finance::BillingStrategy - Alert - Forum - Invitation - MessageRecipient - Metric - Moderatorship - PaymentDetail - PaymentTransaction - PlanMetric - Profile - Topic - TopicCategory - UserTopic
mayorova
force-pushed
the
strong-params-part1
branch
from
a08b299 to
d3304a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is part 1 of the migration from protected attributes to strong parameters.
Protected attributes is an old Rails feature which was deprecated a long time ago. We were using protected_attributes_continued gem to keep it working, but now it's also discontinued and does not support Rails 7+, so it's a blocker for upgrading to Rails 7.2 for us.
This Part 1 handles all simple models that don't have custom attributes (so, excluding Account, User, Cinstance).
Which issue(s) this PR fixes
https://redhat.atlassian.net/browse/THREESCALE-12434
Verification steps
All tests should pass, and all features should work as before.
Special notes for your reviewer: