Draft: Implement Nitsche method to couple embedded meshes#1613
Draft
eulovi wants to merge 16 commits into4C-multiphysics:mainfrom
Draft
Draft: Implement Nitsche method to couple embedded meshes#1613eulovi wants to merge 16 commits into4C-multiphysics:mainfrom
eulovi wants to merge 16 commits into4C-multiphysics:mainfrom
Conversation
amgebauer
reviewed
Dec 18, 2025
Contributor
isteinbrecher
left a comment
There was a problem hiding this comment.
Thanks for the new functionality @eulovi .
I did not have time to go through everything in detail, but I left some general comments.
Comment on lines
+194
to
+201
| Core::LinAlg::SparseMatrix& global_penalty_interface, | ||
| Core::LinAlg::SparseMatrix& global_penalty_background, | ||
| Core::LinAlg::SparseMatrix& global_penalty_interface_background, | ||
| Core::LinAlg::SparseMatrix& global_disp_interface_stress_interface, | ||
| Core::LinAlg::SparseMatrix& global_disp_interface_stress_background, | ||
| Core::LinAlg::SparseMatrix& global_disp_background_stress_interface, | ||
| Core::LinAlg::SparseMatrix& global_disp_background_stress_background, | ||
| Core::LinAlg::FEVector<double>& global_constraint, double& nitsche_stabilization_param, |
Contributor
There was a problem hiding this comment.
I am not so sure about this interface. Why do we need so many matrices? Nitsches method should be like the penalty method, so I would assume that we only need to assemble in the global stiffness matrix and force vector.
Comment on lines
+70
to
+77
| //! Couple strategy between overlapping and underlying meshes | ||
| Constraints::EmbeddedMesh::EmbeddedMeshParams embedded_mesh_coupling_params_; | ||
|
|
||
| //! Pointer to the mortar manager. This object stores the relevant mortar matrices. | ||
| std::shared_ptr<Constraints::EmbeddedMesh::SolidToSolidMortarManager> mortar_manager_; | ||
|
|
||
| //! Pointer to the Nitsche manager. | ||
| std::shared_ptr<Constraints::EmbeddedMesh::SolidToSolidNitscheManager> nitsche_manager_; |
Contributor
There was a problem hiding this comment.
Instead of #1614 you can move the common functionality of the mortar and nitsche manager into this submode evaluator and not require the two to be based on the same base class.
c5dcf5c to
6f0babf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context
In this PR, a non-symmetric Nitsche method is implemented for coupling embedded meshes. This is introduced in the constraint_framework library. For now, I set this as a draft, as there is redundancy in the code and I might have broke some tests from the mortar coupling.
The general strategy for introducing this functionality is the following:
evaluate_global_coupling_contributionsandadd_global_force_stiffness_contributions. Maybe I could do a base class, called coupling_manager that hold the functionality of defining the pairs and doing the setup and define the subclasses ofmortar_managerandnitsche_managerthat have their ownevaluate_global_coupling_contributionsandadd_global_force_stiffness_contributions. Although I am open to ideas.As there is a lot going on here, some clean up should be done in other PRs before merging this one:
get_normal_cauchy_stress_at_xiand to the functions that call it.Related Issues and Pull Requests