Clean up embeddedmesh implementation#1614
Open
eulovi wants to merge 1 commit into4C-multiphysics:mainfrom
Open
Clean up embeddedmesh implementation#1614eulovi wants to merge 1 commit into4C-multiphysics:mainfrom
eulovi wants to merge 1 commit into4C-multiphysics:mainfrom
Conversation
2 tasks
maxfirmbach
reviewed
Dec 23, 2025
Contributor
maxfirmbach
left a comment
maxfirmbach
left a comment
There was a problem hiding this comment.
Overall looks nice 👍. I have left some comments 😃.
| #include "4C_fem_discretization.hpp" | ||
|
|
||
| FOUR_C_NAMESPACE_OPEN | ||
| FOUR_C_NAMESPACE_OPEN namespace Core::IO { class VisualizationManager; } |
| #include <memory> | ||
|
|
||
| // Forward declarations. | ||
| class Map; |
Contributor
There was a problem hiding this comment.
I think we should not forward declare things outside of FOUR_C_NAMESPACE_OPEN.
| { | ||
| class VisualizationManager; | ||
| } | ||
| namespace Solid |
Contributor
There was a problem hiding this comment.
Some blank lines in between would be nice. Currently it looks a bit cramped.
|
|
||
| namespace LinAlg | ||
| { | ||
| class SparseMatrix; |
Contributor
There was a problem hiding this comment.
SparseMatrix is already declared a few lines above.
| namespace Core::LinAlg | ||
| { | ||
| class SparseMatrix; | ||
| class FE_Vector; |
Contributor
There was a problem hiding this comment.
I think FE_Vector does not exist. It should be FEVector I guess.
| return is_cut_node; | ||
| } | ||
|
|
||
| MPI_Comm Constraints::EmbeddedMesh::SolidToSolidCouplingManager::get_my_comm() |
Contributor
There was a problem hiding this comment.
Is this function really necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context
One problem that I noticed in the PR #1613 is that the current
embeddedmeshimplementation inconstraint_frameworkis not flexible enough to add new coupling strategies. So far, only the Mortar method is implemented. Therefore, in this PR a base classSolidToSolidCouplingManageris introduced. This class can work as a base class for other methods and holds basic functionality needed for embedded mesh strategies. Also I tried to clean how parameters are obtained, so that no unnecessary parameters are called if the coupling strategy doesn't require them.Related Issues and Pull Requests
Related to #1613