Skip to content

aegis_grpc: Servoing idling & minor improvments#103

Merged
macmacal merged 8 commits intohumble-develfrom
feature/aegis_grpc/minor_improvments
Feb 16, 2026
Merged

aegis_grpc: Servoing idling & minor improvments#103
macmacal merged 8 commits intohumble-develfrom
feature/aegis_grpc/minor_improvments

Conversation

@macmacal
Copy link
Contributor

@macmacal macmacal commented Feb 16, 2026 •
edited
Loading

Description

Fixes various things and typos:

  • Missing protobuf services in README
  • Adds servoing idle messages (plain zeros) for faster MoveIt2 Servo responing.
  • From now on grpc_client.py have prefixed logging messages,
  • Changed bgr8 assert to if in FillProtoImage() method

Motivation and context

How has this been tested?

Checklist

  • All TODOs in the code have been resolved or linked to a proper issue.
  • Code has been (auto)formatted.
  • Documentation (e.g., README, CHANGELOG, Wiki) has been updated.
  • All automated checks have passed.

Clickup task: 869c46w0b

@macmacal macmacal requested a review from sivral February 16, 2026 14:14
@macmacal macmacal added the enhancement New feature or request label Feb 16, 2026
@macmacal macmacal marked this pull request as draft February 16, 2026 14:14
@macmacal macmacal added grpc moveit2 Issue related to path planning with MoveIt2 framework labels Feb 16, 2026
Base automatically changed from feature/aegis_grpc/tcp_pose_from_tf_transform to humble-devel February 16, 2026 15:55
@macmacal macmacal marked this pull request as ready for review February 16, 2026 15:56
sivral
sivral approved these changes Feb 16, 2026
View reviewed changes
Copy link
Contributor

@sivral sivral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@macmacal macmacal merged commit 242ec27 into humble-devel Feb 16, 2026
1 check passed
@macmacal macmacal deleted the feature/aegis_grpc/minor_improvments branch February 16, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sivral sivral sivral approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request grpc moveit2 Issue related to path planning with MoveIt2 framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@macmacal @sivral