Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 2, 2025

Fix parenthesis error and double version in path.

@dweindl dweindl self-assigned this Nov 2, 2025
@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.03%. Comparing base (de6c323) to head (eafb5bd).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/__init__.py 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3009      +/-   ##
==========================================
- Coverage   76.71%   76.03%   -0.69%     
==========================================
  Files         309      309              
  Lines       19900    19901       +1     
  Branches     1497     1498       +1     
==========================================
- Hits        15267    15132     -135     
- Misses       4620     4756     +136     
  Partials       13       13              
Flag Coverage Δ
cpp 72.49% <33.33%> (-0.01%) ⬇️
cpp_python 37.90% <0.00%> (-0.01%) ⬇️
petab 38.53% <33.33%> (-0.01%) ⬇️
petab_sciml 14.15% <0.00%> (-0.01%) ⬇️
python 69.32% <33.33%> (-0.01%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/__init__.py 93.75% <33.33%> (-1.49%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review November 2, 2025 10:28
@dweindl dweindl requested a review from a team as a code owner November 2, 2025 10:28
@dweindl dweindl enabled auto-merge November 2, 2025 10:29
Fix parenthesis error and double version in path.
@dweindl dweindl added this pull request to the merge queue Nov 2, 2025
Merged via the queue into AMICI-dev:main with commit 7d57ed7 Nov 2, 2025
17 of 19 checks passed
@dweindl dweindl deleted the fix_model_dir branch November 3, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants