Skip to content

Fix get_model_dir #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dweindl merged 1 commit into from
Nov 2, 2025
Merged

Fix get_model_dir #3009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions python/sdist/amici/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ def _imported_from_setup() -> bool:
def get_model_root_dir() -> Path:
"""Get the default root directory for AMICI models.

Get the default root directory for AMICI models for the current AMICI
version.

:return:
The model root directory.
This defaults to `{base_dir}/{amici_version}`.
Expand Down Expand Up @@ -116,11 +119,11 @@ def get_model_dir(model_id: str | None = None, jax: bool = False) -> Path:
if model_id is None:
import tempfile

return Path(
tempfile.mkdtemp(dir=base_dir / __version__), suffix=suffix
)
# mkdtemp requires the parent directory to exist
base_dir.mkdir(parents=True, exist_ok=True)
return Path(tempfile.mkdtemp(dir=base_dir, suffix=suffix))

return base_dir / __version__ / (model_id + suffix)
return base_dir / (model_id + suffix)


# Initialize AMICI paths
Expand Down
Loading