Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 11, 2025

More efficient equality check:

  • Check equality before simplification
  • Respect DEModel._simplify for simplification

This makes a very noticable difference for some models.

More efficient equality check:
* Check equality before simplification
* Respect DEModel._simplify for simplification

This makes a very noticable difference for some models.
@dweindl dweindl self-assigned this Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.39%. Comparing base (1e8cf9c) to head (a4eb11b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3024      +/-   ##
==========================================
- Coverage   78.01%   77.39%   -0.62%     
==========================================
  Files         311      311              
  Lines       20584    20584              
  Branches     1499     1499              
==========================================
- Hits        16059    15932     -127     
- Misses       4515     4642     +127     
  Partials       10       10              
Flag Coverage Δ
cpp 70.32% <100.00%> (+0.01%) ⬆️
cpp_python 36.74% <100.00%> (ø)
petab 45.71% <100.00%> (ø)
petab_sciml 13.65% <0.00%> (ø)
python 69.33% <100.00%> (+<0.01%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/de_model.py 92.12% <100.00%> (-0.39%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review November 12, 2025 07:06
@dweindl dweindl requested a review from a team as a code owner November 12, 2025 07:06
@dweindl dweindl enabled auto-merge November 12, 2025 07:06
@dweindl dweindl added this pull request to the merge queue Nov 12, 2025
Merged via the queue into AMICI-dev:main with commit b8c0fef Nov 12, 2025
25 of 26 checks passed
@dweindl dweindl deleted the faster_get_unique_root branch November 12, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants