Skip to content

Faster DEModel._get_unique_root #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dweindl merged 1 commit into from
Nov 12, 2025
Merged

Faster DEModel._get_unique_root #3024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/sdist/amici/de_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2445,7 +2445,9 @@ def _get_unique_root(
return None

for root in roots:
if sp.simplify(root_found - root.get_val()).is_zero:
if (difference := (root_found - root.get_val())).is_zero or (
self._simplify and self._simplify(difference).is_zero
):
return root.get_sym()

# create an event for a new root function
Expand Down
Loading