Implement pure-SoA HDF5 particle IO#5204
Merged
atmyers merged 4 commits intoAMReX-Codes:developmentfrom Mar 25, 2026
Merged
Conversation
WeiqunZhang
approved these changes
Mar 25, 2026
Member
|
@atmyers @WeiqunZhang I see in HPSF CI on H100 issues with:
Could this be from this PR? |
Member
|
The failure can probably be reproduced locally. The issue is probably single precision build trying to read double precision data. If we cannot fix them quickly on Monday 3/30, maybe we can disable them for single precision so that we don't release 26.04 with known CTest issues. |
Member
|
Member
|
I think the issue is casting int to float for reduction. |
Member
ax3l
pushed a commit
that referenced
this pull request
Mar 30, 2026
For floating-point number comparison, use amrex::almostEqual instead of ==. For int data, cast them to amrex::Long instead of amrex::Real (which might be float) before reduction. Follow-up to #5204
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #5152. Although it's a bit worse than that issue indicated, HDF5 particle IO wasn't implemented for pure SoA at all. This PR does so.
The proposed changes: