Fix particle dual-grid test#5255
Merged
ax3l merged 1 commit intoAMReX-Codes:developmentfrom Mar 30, 2026
Merged
Conversation
For floating-point number comparison, use amrex::almostEqual instead of ==. For int data, cast them to amrex::Long instead of amrex::Real (which might be float) before reduction.
5 tasks
Member
Author
|
/run-hpsf-gitlab-ci |
|
GitLab CI has started at https://gitlab.spack.io/amrex/amrex/-/pipelines/1499320. |
|
GitLab CI 1499320 finished with status: success. See details at https://gitlab.spack.io/amrex/amrex/-/pipelines/1499320. |
atmyers
approved these changes
Mar 30, 2026
Member
|
Thank you! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For floating-point number comparison, use amrex::almostEqual instead of ==.
For int data, cast them to amrex::Long instead of amrex::Real (which might be float) before reduction.
Follow-up to #5204