Linear Solver Tests: Loosen convergence tolerance for single precision - #5319
Merged
Conversation
This should solve the HPSF GitLab CI failures. The tests started to fail after AMReX-Codes#5305, not because that PR introduced a bug, but because that PR fixed a CMake bug that prevented the tests from running. A similar CMake bug is also fixed in this PR.
Member
Author
|
/run-hpsf-gitlab-ci |
|
GitLab CI has started at https://gitlab.spack.io/amrex/amrex/-/pipelines/1521836. |
|
GitLab CI 1521836 finished with status: failed. See details at https://gitlab.spack.io/amrex/amrex/-/pipelines/1521836. |
WeiqunZhang
changed the title
Member
Author
|
/run-hpsf-gitlab-ci |
|
GitLab CI has started at https://gitlab.spack.io/amrex/amrex/-/pipelines/1521862. |
|
GitLab CI 1521862 finished with status: success. See details at https://gitlab.spack.io/amrex/amrex/-/pipelines/1521862. |
asalmgren
approved these changes
Apr 12, 2026
WeiqunZhang
added a commit
that referenced
this pull request
Sep 10, 2026
Build in single precision with EB, linear solvers, AmrLevel, particles and FFT, then run ctest and clang-tidy. Single precision was only exercised by the GitLab H100 GPU runs, so solver breakage kept surfacing late: #4785, #5319 and #5672. The job found a float-conversion bug in the 2D nodal EB kernel and a NodeTensorLap tolerance that cannot be met in float. 263 -Wfloat-conversion lines remain under Tests/, so that warning is not an error in this job yet; cleanup follows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should solve the HPSF GitLab CI failures.
The tests started to fail after #5305, not because that PR introduced a bug, but because that PR fixed a CMake bug that prevented the tests from running.
A similar CMake bug is also fixed in this PR.