Skip to content

Linear Solver Tests: Loosen convergence tolerance for single precision #5319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WeiqunZhang merged 2 commits into from
Apr 12, 2026
+19 −4
Merged

Linear Solver Tests: Loosen convergence tolerance for single precision #5319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dec448b
CurlCurl Test: Loosen convergence tolerance for single precision
WeiqunZhang Apr 12, 2026
2e6ae01
loosen ABecLaplacian test's tolerance
WeiqunZhang Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/LinearSolvers/ABecLaplacian_C/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
foreach(D IN LISTS AMReX_SPACEDIM)
if (D EQUAL 1)
return()
continue()
endif ()

set(_sources
Expand Down
14 changes: 12 additions & 2 deletions Tests/LinearSolvers/ABecLaplacian_C/MyTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,12 @@ MyTest::solvePoisson ()
info.setDeterministic(deterministic);
info.setMaxCoarseningLevel(max_coarsening_level);

const auto tol_rel = Real(1.e-10);
Real tol_rel;
if constexpr (std::is_same_v<double,Real>) {
tol_rel = Real(1.0e-10);
} else {
tol_rel = Real(1.0e-4);
}
const auto tol_abs = Real(0.0);

const auto nlevels = static_cast<int>(geom.size());
Expand Down Expand Up @@ -157,7 +162,12 @@ MyTest::solveABecLaplacian ()
info.setMaxCoarseningLevel(max_coarsening_level);
info.setMaxSemicoarseningLevel(max_semicoarsening_level);

const auto tol_rel = Real(1.e-10);
Real tol_rel;
if constexpr (std::is_same_v<double,Real>) {
tol_rel = Real(1.0e-10);
} else {
tol_rel = Real(1.0e-4);
}
const auto tol_abs = Real(0.0);

const auto nlevels = static_cast<int>(geom.size());
Expand Down
7 changes: 6 additions & 1 deletion Tests/LinearSolvers/CurlCurl/MyTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,12 @@ MyTest::solve ()
mf.setVal(Real(0));
}

auto tol_rel = Real(1.0e-10);
Real tol_rel;
if constexpr (std::is_same_v<double,Real>) {
tol_rel = Real(1.0e-10);
} else {
tol_rel = Real(1.0e-4);
}
auto tol_abs = Real(0.0);

if (use_gmres)
Expand Down
Loading