Skip to content

#329: Update issue templates to spring 2025 standard#330

Merged
benedeki merged 6 commits intomasterfrom
feature/329-update-issue-templates-to-spring-2025-standard
May 9, 2025
Merged

#329: Update issue templates to spring 2025 standard#330
benedeki merged 6 commits intomasterfrom
feature/329-update-issue-templates-to-spring-2025-standard

Conversation

@benedeki
Copy link
Contributor

@benedeki benedeki commented Apr 8, 2025

  • added issue type to templates
  • removed tasklist from Epic and Spike
  • fixing Release notes presence check workflow

Closes #329

* added issue type to templates
* removed tasklist from Epic and Spike
@benedeki benedeki added the no RN No release notes required label Apr 8, 2025
@benedeki benedeki self-assigned this Apr 8, 2025
@benedeki benedeki requested a review from Copilot April 8, 2025 11:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/ISSUE_TEMPLATE/spike_task.md:5

  • [nitpick] The type value 'Task' in the Spike template might be too generic given the template name is 'Spike'. Consider using a type value like 'Spike' for clearer intent.
type: 'Task'

.github/ISSUE_TEMPLATE/question.md:5

  • [nitpick] The type value 'Task' in the Question template could be misleading; aligning it with the template name (e.g., 'Question') may improve clarity.
type: 'Task'

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

Report: Jacoco Report on atum-model for scala:2.13.11

Metric (instruction) Coverage Threshold Status
Overall 56.51% 56.0%
Changed Files 0.0% 80.0%
File Path Coverage Threshold Status

No changed file in reports.

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

Report: Jacoco Report on atum-reader for scala:2.13.11

Metric (instruction) Coverage Threshold Status
Overall 95.1% 56.0%
Changed Files 0.0% 80.0%
File Path Coverage Threshold Status

No changed file in reports.

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

Report: Jacoco Report on atum-agent for spark:3.3.2 - scala:2.13.11

Metric (instruction) Coverage Threshold Status
Overall 80.52% 56.0%
Changed Files 0.0% 80.0%
File Path Coverage Threshold Status

No changed file in reports.

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

Report: Jacoco Report on atum-server for scala:2.13.11

Metric (instruction) Coverage Threshold Status
Overall 68.39% 56.0%
Changed Files 0.0% 80.0%
File Path Coverage Threshold Status

No changed file in reports.

@benedeki benedeki added no RN No release notes required and removed no RN No release notes required labels Apr 8, 2025
@benedeki benedeki added the no RN No release notes required label Apr 8, 2025
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changes review

#

name: Check PR Release Notes in Description
name: Check PR Release Notes Presence Check
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Check PR Release Notes Presence Check
name: Check PR Release Notes Presence in Description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am little torn on this. Adding the info into the name is good. But my experience is, that if it differs from filename or workflow name, it leads to confusion.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, so let's change the job name, too. ok?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the same now, isn't it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not. To be same there is need to rename the job name to "Release Notes Presence Check"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not it's not 🙄

@benedeki benedeki merged commit e41c369 into master May 9, 2025
9 checks passed
@benedeki benedeki deleted the feature/329-update-issue-templates-to-spring-2025-standard branch May 9, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no RN No release notes required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update issue templates to spring 2025 standard

4 participants