Skip to content

#329: Update issue templates to spring 2025 standard #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benedeki merged 6 commits into from
May 9, 2025
Merged

#329: Update issue templates to spring 2025 standard #330

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
72d02f1
#329: Update issue templates to spring 2025 standard
benedeki Apr 8, 2025
30ac529
* fixing _Release notes presence check_ workflow
benedeki Apr 8, 2025
5d1a5dc
* updated jacoco_report action to v1
benedeki Apr 14, 2025
c80d6f4
* removed Question template
benedeki Apr 14, 2025
f446336
* improve on JaCoco workflow job and step names
benedeki May 7, 2025
b3fffaf
Merge branch 'master' into feature/329-update-issue-templates-to-spri…
benedeki May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Bug report
about: Create a report to help us improve
labels: 'bug'

type: 'Bug'
---

## Describe the bug
Expand Down
6 changes: 2 additions & 4 deletions .github/ISSUE_TEMPLATE/epic_task.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
name: Epic
about: A larger task consisting of more deliverables
labels: 'epic'
type: 'Epic'
---

## Background
Expand All @@ -10,7 +11,4 @@ A clear and concise intro into the situation.
## Goal
The goal that epic wants to achieve.

```[tasklist]
### Tasks
- [ ] Add a draft title or issue reference here
```
[Add actionable subtasks or even epics]
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Feature request
about: Suggest an idea for this project
labels: 'enhancement'

type: 'Feature'
---

## Background
Expand Down
13 changes: 0 additions & 13 deletions .github/ISSUE_TEMPLATE/question.md
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions .github/ISSUE_TEMPLATE/spike_task.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Spike
about: Issue template for spikes, research and investigation tasks
labels: 'spike'

type: 'Task'
---

## Background
Expand All @@ -20,14 +20,12 @@ Feel free to add information about why it's needed and what assumptions you have

The list of desired outcomes of this spike ticket.

```[tasklist]
### Tasks
- [ ] Questions have been answered or we have a clearer idea of how to get to our goal
- [ ] Discussion with the team
- [ ] Documentation
- [ ] Create recommendations and new implementation tickets
- [ ] item here..
```

## Additional Info/Resources [Optional]

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/jacoco_report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:

- name: Add JaCoCo Report in PR comments
id: jacoco
uses: MoranaApps/jacoco-report@v0.2.1
uses: MoranaApps/jacoco-report@v1
with:
token: '${{ secrets.GITHUB_TOKEN }}'
paths: |
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/release-notes-presence-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# limitations under the License.
#

name: Check PR Release Notes in Description
name: Check PR Release Notes Presence Check
Copy link
Copy Markdown
Collaborator

@miroslavpojer miroslavpojer Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Check PR Release Notes Presence Check
name: Check PR Release Notes Presence in Description

Copy link
Copy Markdown
Contributor Author

@benedeki benedeki Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am little torn on this. Adding the info into the name is good. But my experience is, that if it differs from filename or workflow name, it leads to confusion.

Copy link
Copy Markdown
Collaborator

@miroslavpojer miroslavpojer Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, so let's change the job name, too. ok?

Copy link
Copy Markdown
Contributor Author

@benedeki benedeki May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the same now, isn't it?

Copy link
Copy Markdown
Collaborator

@miroslavpojer miroslavpojer May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not. To be same there is need to rename the job name to "Release Notes Presence Check"

Copy link
Copy Markdown
Contributor Author

@benedeki benedeki May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not it's not 🙄


on:
pull_request:
Expand Down Expand Up @@ -42,3 +42,4 @@ jobs:
with:
github-repository: ${{ github.repository }}
pr-number: ${{ github.event.number }}
skip-labels: "no RN"
Loading