MDL 1.9 updates #2102
Merged
MDL 1.9 updates #2102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krohmerNV
force-pushed
the
PR-mdl-1.9-update
branch
2 times, most recently
from
10412ee to
1bebc31
Compare
ld-kerley
approved these changes
Nov 11, 2024
Contributor
ld-kerley
left a comment
ld-kerley
left a comment
There was a problem hiding this comment.
Overall looks good to me - I left a couple of small notes below - but nothing major.
I don't have a way to test the MDL backend at the moment - so relying on the unit tests and you to validate its generating the correct images etc, but code structure etc looks good to me.
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks like a great set of improvements, thanks @krohmerNV, and I had just a few recommendations for edits.
…tion from material IOR Minor updates: - improve MDL printing by adding named parameters - handle 1-element mixes (basically scale) above layers - improve blur and hight to normal to return something meaningful (before totally broken) - improve non-material outputs that can be rendered, e.g. float3x3 and float4x4
krohmerNV
force-pushed
the
PR-mdl-1.9-update
branch
from
75a6749 to
2a91121
Compare
Contributor
Author
|
@jstone-lucasfilm @ld-kerley |
jstone-lucasfilm
approved these changes
Nov 21, 2024
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks like a great set of improvements, thanks @krohmerNV!
jstone-lucasfilm
merged commit a3a7744
into
AcademySoftwareFoundation:main
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new version to GenMDL and remove uniform restriction from material IOR
Minor updates: