Skip to content

Speedup to detect the existence of files on Windows #4977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgritz merged 1 commit into from
Dec 12, 2025
Merged

Speedup to detect the existence of files on Windows #4977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/libutil/filesystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,15 @@ Filesystem::path_is_absolute(string_view path, bool dot_is_absolute)
bool
Filesystem::exists(string_view path) noexcept
{
#ifdef _WIN32
// filesystem::exists is slow on Windows for network paths, so use the
// WinAPI directly
return INVALID_FILE_ATTRIBUTES
!= GetFileAttributesW(Strutil::utf8_to_utf16wstring(path).c_str());
#else
error_code ec;
return filesystem::exists(u8path(path), ec);
#endif
}


Expand Down
Loading