Speedup to detect the existence of files on Windows #4977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Collaborator
|
This looks fine to me. Does anybody with Windows experience wish to comment? |
Signed-off-by: Jackson Sun <[email protected]>
Contributor
|
I'm certainly not a Win32 expert, but this seems correct based on my understanding and some spelunking in the MSVC STL source (which, in hindsight, is not an activity I would recommend). |
lgritz
approved these changes
Dec 12, 2025
Collaborator
|
LGTM. The bleeding edge CI test failure is entirely unrelated and happening on all branches. I'm investigating separately. |
lgritz
merged commit ae04b6e
into
AcademySoftwareFoundation:main
28 of 29 checks passed
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Dec 17, 2025
…oundation#4977) On Windows, `Filesystem::exists` forward the call to `std::filesystem::exists`, and finally calls `_std_fs_get_stats` . `_std_fs_get_stats` is slow if the argument is a netwok path. Signed-off-by: Jackson Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Windows,
Filesystem::existsforward the call tostd::filesystem::exists, and finally calls_std_fs_get_stats._std_fs_get_statsis slow if the argument is a netwok path.Tests
No, performance related.
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.