Skip to content

testing: fix shell command quoting to work the same on Unix and Windows #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgritz merged 1 commit into from
Jan 25, 2025
Merged

testing: fix shell command quoting to work the same on Unix and Windows #1925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testsuite/lazytrace/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@

# Run once with default (lazytrace=1), and once explicitly disabled
command += testshade(shader_commands)
command += testshade("{} --options 'lazytrace=0'".format(shader_commands))
command += testshade("{} --options \"lazytrace=0\"".format(shader_commands))
4 changes: 2 additions & 2 deletions testsuite/reparam-string/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@

command += testshade(" ".join([
"--layer lay0",
"--param:type=string:interactive=1 test_string 'initial value'",
"--param:type=string:interactive=1 test_string \"initial value\"",
"test --iters 2",
"--reparam:type=string:interactive=1 lay0 test_string 'updated value'",
"--reparam:type=string:interactive=1 lay0 test_string \"updated value\"",
]))

outputs = [ "out.txt" ]
Expand Down
Loading