Skip to content

Include entry layer name in PTX cache key #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgritz merged 1 commit into from
Mar 7, 2025
Merged

Include entry layer name in PTX cache key #1954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/liboslexec/instance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,10 +857,14 @@ ShaderGroup::generate_optix_cache_key(string_view code)
safegroup = Strutil::replace(name(), "/", "_", true);
safegroup = Strutil::replace(safegroup, ":", "_", true);

// Cache key includes the groupname in addition to the serialized IR.
// This is because the groupname makes its way into the ptx's direct callable name,
// but isn't included in the serialization.
std::string cache_key = fmtformat("cache-osl-ptx-{}-{}", safegroup, ir_key);
ShaderInstance* inst = layer(nlayers() - 1);
ustring layername = inst->layername();

// Cache key includes group and entry layer names in addition to the serialized IR.
// This is because the group and layer names make their way into the ptx's
// direct callable name, but isn't included in the serialization.
std::string cache_key = fmtformat("cache-osl-ptx-{}-{}-{}", safegroup,
layername, ir_key);

m_optix_cache_key = cache_key;
}
Expand Down
Loading