Skip to content

Conversation

jminor
Copy link
Collaborator

@jminor jminor commented Aug 1, 2025

Sometimes you have effects in your timeline that you want to remove. This PR adds a --remove-effects option to otiotool to make that easy and convenient.

Example:

otiotool -i effects.otio --remove-effects -o no-effects.otio

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.95%. Comparing base (c0e97b0) to head (353e71b).
⚠️ Report is 63 commits behind head on main.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1912      +/-   ##
==========================================
+ Coverage   84.11%   84.95%   +0.83%     
==========================================
  Files         198      181      -17     
  Lines       22241    13073    -9168     
  Branches     4687     1209    -3478     
==========================================
- Hits        18709    11106    -7603     
+ Misses       2610     1781     -829     
+ Partials      922      186     -736     
Flag Coverage Δ
py-unittests 84.95% <100.00%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-opentimelineio/opentimelineio/console/otiotool.py 64.45% <100.00%> (-1.86%) ⬇️
tests/test_console.py 95.50% <100.00%> (+0.17%) ⬆️

... and 136 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 639f57c...353e71b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is the removal of -O otio_json in the test just to remove the explicit .json output?

@jminor
Copy link
Collaborator Author

jminor commented Aug 15, 2025

@ssteinbach yes, those -O otio_json options were redundant. That is automatically inferred from the file extension. I just cleaned that up while I was in there so folks wouldn't think that's required.

@jminor jminor merged commit 1b3ece1 into AcademySoftwareFoundation:main Aug 15, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants