Error: multiple definition of `threadsafe_assign'#71
Closed
Jamaika1 wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Closed
Error: multiple definition of `threadsafe_assign'#71Jamaika1 wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Jamaika1 wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
https://forum.doom9.org/showthread.php?t=185868 Signed-off-by: Jamaika1 <lukaszcz18@wp.pl>
Signed-off-by: Jamaika1 <lukaszcz18@wp.pl>
Author
1 similar comment
Author
kpchoi
requested changes
May 5, 2025
| tpool_result_t oapv_tpool_sync_obj_delete(oapv_sync_obj_t *sobj); | ||
| int oapv_tpool_spinlock_wait(volatile int *addr, int val); | ||
| void threadsafe_assign(volatile int *addr, int val); | ||
| void threadsafe_assign_oapv(volatile int *addr, int val); |
Collaborator
There was a problem hiding this comment.
I think we need to remove this declaration because it may not be used in other c-code.
| } | ||
|
|
||
| void threadsafe_assign(volatile int *addr, int val) | ||
| void threadsafe_assign_oapv(volatile int *addr, int val) |
Collaborator
There was a problem hiding this comment.
It is recommended to use 'static' function rather than adding suffix ('_oapv').
And the the symbol would not be exported to explicitly.
Author
There was a problem hiding this comment.
GCC won't accept that. Unless it's static in xeve and openapv. From what I see xeve is no longer updated.
Collaborator
There was a problem hiding this comment.
When I checked the code, it found the threadsafe_assign() function is not used in openapv.
I think the best way is to remove the fuction in this time.
Collaborator
|
This change has applied to PR #88 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.