Skip to content

Error: multiple definition of `threadsafe_assign' #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jamaika1 wants to merge 2 commits into from
Closed

Error: multiple definition of `threadsafe_assign' #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7843080
Error: multiple definition of `threadsafe_assign'
Jamaika1 May 5, 2025
0b2f3c7
Error: multiple definition of `threadsafe_assign'
Jamaika1 May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/oapv_tpool.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ int oapv_tpool_spinlock_wait(volatile int *addr, int val)
return temp;
}

void threadsafe_assign(volatile int *addr, int val)
void threadsafe_assign_oapv(volatile int *addr, int val)
Copy link
Collaborator

@kpchoi kpchoi May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to use 'static' function rather than adding suffix ('_oapv').
And the the symbol would not be exported to explicitly.

Copy link
Author

@Jamaika1 Jamaika1 May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCC won't accept that. Unless it's static in xeve and openapv. From what I see xeve is no longer updated.

Copy link
Collaborator

@kpchoi kpchoi May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I checked the code, it found the threadsafe_assign() function is not used in openapv.
I think the best way is to remove the fuction in this time.

{
// thread safe volatile assign
*addr = val;
Expand Down
2 changes: 1 addition & 1 deletion src/oapv_tpool.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ tpool_result_t oapv_tpool_deinit(oapv_tpool_t *tp);
oapv_sync_obj_t oapv_tpool_sync_obj_create();
tpool_result_t oapv_tpool_sync_obj_delete(oapv_sync_obj_t *sobj);
int oapv_tpool_spinlock_wait(volatile int *addr, int val);
void threadsafe_assign(volatile int *addr, int val);
void threadsafe_assign_oapv(volatile int *addr, int val);
Copy link
Collaborator

@kpchoi kpchoi May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to remove this declaration because it may not be used in other c-code.


void oapv_tpool_enter_cs(oapv_sync_obj_t sobj);
void oapv_tpool_leave_cs(oapv_sync_obj_t sobj);
Expand Down