Do not run remote installer test in non-interactive mode. #3607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-as
force-pushed
the
mitchell/dx-3173
branch
4 times, most recently
from
a18282b to
7a16308
Compare
mitchell-as
force-pushed
the
mitchell/dx-3173
branch
from
7a16308 to
cef990a
Compare
MDrakos
approved these changes
Nov 26, 2024
| stateExePath := filepath.Join(installPath, "bin", constants.StateCmd+osutils.ExeExtension) | ||
|
|
||
| args := []string{"-n"} | ||
| args := []string{"--non-interactive"} |
Collaborator
Author
There was a problem hiding this comment.
It did, but I like that this is more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we need to be running in non-interactive mode because the Windows installer detects installation as admin and prompts you to continue. I've updated the test to stop trying to send "Y" to the TOS prompt and instead assert it's continuing due to non-interactive mode. There's an extra assertion for Windows so we do not forget this use-case.