Skip to content

Do not run remote installer test in non-interactive mode. #3607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchell-as merged 1 commit into from
Nov 26, 2024
Merged

Do not run remote installer test in non-interactive mode. #3607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions test/integration/remote_installer_int_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (suite *RemoteInstallIntegrationTestSuite) TestInstall() {
installPath := filepath.Join(ts.Dirs.Work, "install")
stateExePath := filepath.Join(installPath, "bin", constants.StateCmd+osutils.ExeExtension)

args := []string{"-n"}
args := []string{"--non-interactive"}
Copy link
Member

@MDrakos MDrakos Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did -n not work?

Copy link
Collaborator Author

@mitchell-as mitchell-as Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did, but I like that this is more explicit.

if tt.Version != "" {
args = append(args, "--version", tt.Version)
}
Expand All @@ -93,10 +93,15 @@ func (suite *RemoteInstallIntegrationTestSuite) TestInstall() {
)

cp.Expect("Terms of Service")
cp.SendLine("Y")
cp.Expect("Continuing because State Tool is running in non-interactive mode")
cp.Expect("Downloading")
cp.Expect("Running Installer...")
cp.Expect("Installing")
if runtime.GOOS == "windows" {
cp.Expect("You are installing the State Tool as an admin")
cp.Expect("Are you sure")
cp.Expect("Continuing because State Tool is running in non-interactive mode")
}
cp.Expect("Installation Complete")
cp.Expect("Press ENTER to exit")
cp.SendEnter()
Expand Down
Loading