Skip to content

Conversation

@mitchell-as
Copy link
Collaborator

@mitchell-as mitchell-as commented Dec 24, 2024

StoryDX-3176 `--output json` should always set non-interactive

@mitchell-as
Copy link
Collaborator Author

The lone failure is a sporadic one.

@mitchell-as mitchell-as marked this pull request as ready for review December 24, 2024 18:42
Comment on lines +299 to +301
if prime.Output().Type().IsStructured() {
globals.NonInteractive = true
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is called after our outputer is updated to use the type given on the command line, so we know at this time if it's structured (e.g. json) or not (e.g. plain).

@mitchell-as mitchell-as requested a review from SkyLeite December 24, 2024 18:45
@mitchell-as mitchell-as reopened this Dec 27, 2024
@mitchell-as mitchell-as merged commit c210e20 into version/0-48-0-RC1 Dec 27, 2024
24 of 29 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-3176 branch December 27, 2024 17:30
@mitchell-as mitchell-as removed the request for review from SkyLeite December 27, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants