Skip to content

Turn on non-interactive mode for structured output. #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchell-as merged 1 commit into from
Dec 27, 2024
Merged

Turn on non-interactive mode for structured output. #3625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmd/state/internal/cmdtree/cmdtree.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,12 @@ func newStateCommand(globals *globalOptions, prime *primer.Values) *captain.Comm
Shorthand: "o",
Description: locale.T("flag_state_output_description"),
Persist: true,
Value: &globals.Output,
OnUse: func() {
if prime.Output().Type().IsStructured() {
globals.NonInteractive = true
}
Comment on lines +299 to +301
Copy link
Collaborator Author

@mitchell-as mitchell-as Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is called after our outputer is updated to use the type given on the command line, so we know at this time if it's structured (e.g. json) or not (e.g. plain).

},
Value: &globals.Output,
},
{
Name: "non-interactive", // Name and Shorthand should be kept in sync with cmd/state/output.go
Expand Down
Loading