-
Notifications
You must be signed in to change notification settings - Fork 14
Start building on and for ARM. #3632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
faf044e
Update outdated action.
mitchell-as 5ae7757
Start building on and for ARM.
mitchell-as 9d297c6
Add "arch" param to install script's state-update URLs.
mitchell-as 276641b
Temporarily add step to install ARM64 from local install.sh
mitchell-as a44f86b
Fixed sysinfo support for arm64.
mitchell-as f5fa90e
Use arm64 version of parallelize.
mitchell-as 28097d4
Most generator scripts are standalone.
mitchell-as 0862380
Do not force amd64 arch for generating update files.
mitchell-as 4697d9e
Do not use gotestfmt action.
mitchell-as 8272c2d
When checking for updates, include arch param.
mitchell-as 1ca0ac6
Use 'contains' for ARM runner check.
mitchell-as 4c06f0b
Skip running nightly integration tests on ARM.
mitchell-as 2099197
Temporarily skip some install and update integration tests on ARM.
mitchell-as File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
Binary file not shown.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,6 +41,7 @@ jobs: | |
| - {os: ubuntu-latest} | ||
| - {os: macos-13, shell: zsh} | ||
| - {os: windows-2019} | ||
| - {os: ubuntu-24.04-arm} | ||
| fail-fast: false | ||
| runs-on: ${{ matrix.sys.os }} | ||
| env: | ||
|
|
@@ -74,19 +75,30 @@ jobs: | |
|
|
||
| # === Install gotestfmt === | ||
| - name: Set up gotestfmt | ||
| uses: gotesttools/gotestfmt-action@v2 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| shell: bash | ||
| run: go install github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt@latest | ||
|
|
||
| - # === Install State Tool === | ||
| name: Install State Tool | ||
| uses: ActiveState/setup-state-tool@v1 | ||
| if: "!contains(matrix.sys.os, 'arm')" | ||
|
|
||
| - # === Install State Tool (ARM64) === | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is temporary until we have an official ARM release that can be installed by a bare |
||
| name: Install State Tool (ARM64) | ||
| if: contains(matrix.sys.os, 'arm') | ||
| shell: bash | ||
| run: | | ||
| ./installers/install.sh -b beta | ||
| echo "$HOME/.local/ActiveState/StateTool/beta/bin" >> $GITHUB_PATH | ||
| "$HOME/.local/ActiveState/StateTool/beta/bin/state" config set optin.unstable true | ||
|
|
||
| - # === Setup === | ||
| name: Setup | ||
| shell: bash | ||
| run: | | ||
| bin=$(pwd)/.github/deps/${{ runner.os }}/bin | ||
| arch="amd64" | ||
| if [[ ${{ contains(matrix.sys.os, 'arm') }} = true ]]; then arch="arm64"; fi | ||
| bin=$(pwd)/.github/deps/${{ runner.os }}/$arch/bin | ||
| echo "Adding $bin to PATH" | ||
| echo "$bin" >> $GITHUB_PATH | ||
|
|
||
|
|
@@ -125,7 +137,6 @@ jobs: | |
| shell: bash | ||
| timeout-minutes: 15 | ||
| run: | | ||
| export PATH="$(pwd)/.github/deps/${{ runner.os }}/bin:$PATH" | ||
| parallelize "$(cat <<'EOF' | ||
| [ | ||
| { | ||
|
|
@@ -262,7 +273,7 @@ jobs: | |
|
|
||
| - # === Configure AWS credentials == | ||
| name: Configure AWS credentials | ||
| uses: aws-actions/configure-aws-credentials@v2 | ||
| uses: aws-actions/configure-aws-credentials@v4 | ||
| with: | ||
| role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }} | ||
| role-session-name: ${{ env.AWS_ROLE_SESSION_NAME }} | ||
|
|
@@ -325,6 +336,10 @@ jobs: | |
| fi | ||
| else | ||
| TEST_SUITE_TAGS="all" | ||
| if [[ ${{ contains(matrix.sys.os, 'arm') }} = true ]]; then | ||
| echo "Skipping integration tests on ARM" | ||
| exit 0 | ||
| fi | ||
| fi | ||
|
|
||
| echo "Running integration tests with tags: $TEST_SUITE_TAGS (empty means every test not specifically tagged)" | ||
|
|
@@ -483,7 +498,7 @@ jobs: | |
|
|
||
| - # === Configure AWS credentials == | ||
| name: Configure AWS credentials | ||
| uses: aws-actions/configure-aws-credentials@v2 | ||
| uses: aws-actions/configure-aws-credentials@v4 | ||
| with: | ||
| role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }} | ||
| role-session-name: ${{ env.AWS_ROLE_SESSION_NAME }} | ||
|
|
@@ -511,3 +526,4 @@ jobs: | |
| session-build-ubuntu-20.04 | ||
| session-build-macos-11 | ||
| session-build-windows-2019 | ||
| session-build-ubuntu-24.04-arm | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GitHub Action pulls down x86 binaries :(
go installdoes the right thing here.