Start building on and for ARM. #3632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-as
force-pushed
the
mitchell/dx-3211
branch
7 times, most recently
from
f11eb2e to
81f6a2d
Compare
The github action uses an install.sh that doesn't have the necessary "arch" param from the previous commit.
Avoid arm64 runtime sourcing issues.
It downloads hardcoded amd64 binaries, which fails on arm64. Using `go install` should do the right thing.
mitchell-as
force-pushed
the
mitchell/dx-3211
branch
from
b2925d7 to
4697d9e
Compare
mitchell-as
commented
Jan 27, 2025
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| shell: bash | ||
| run: go install github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt@latest |
Collaborator
Author
There was a problem hiding this comment.
The GitHub Action pulls down x86 binaries :( go install does the right thing here.
mitchell-as
commented
Jan 27, 2025
| uses: ActiveState/setup-state-tool@v1 | ||
| if: matrix.sys.os != 'ubuntu-24.04-arm' | ||
|
|
||
| - # === Install State Tool (ARM64) === |
Collaborator
Author
There was a problem hiding this comment.
This is temporary until we have an official ARM release that can be installed by a bare ./install.sh call via the above GitHub Action.
mitchell-as
added
Test: update
Test: install-scripts
Test: installer
Test: install
and removed
Test: critical
labels
mitchell-as
force-pushed
the
mitchell/dx-3211
branch
from
79e84e6 to
0f24e36
Compare
Avoid repeated use of full runner name.
mitchell-as
force-pushed
the
mitchell/dx-3211
branch
from
0f24e36 to
df60536
Compare
mitchell-as
force-pushed
the
mitchell/dx-3211
branch
from
df60536 to
2099197
Compare
Collaborator
Author
|
Flagging for review to figure out what we want to do with this (see description). I am aware we might want to let this bake for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if we want to merge this into the v48 branch for a "soft" release from CI, or if we want to leave this in PR form for BE to play with.