Skip to content

Conversation

@BelKed
Copy link
Contributor

@BelKed BelKed commented Mar 4, 2025


Important

Convert audible and incognito properties to booleans in heartbeat() in heartbeat.ts.

  • Behavior:
    • Change audible and incognito properties in heartbeat() from strings to booleans in heartbeat.ts.
    • Handles cases where audible is undefined by defaulting to false.

This description was created by Ellipsis for 060ec52. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 060ec52 in 31 seconds

More details
  • Looked at 15 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. src/background/heartbeat.ts:34
  • Draft comment:
    Good: Changing audible from string to boolean resolves type issues.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. src/background/heartbeat.ts:35
  • Draft comment:
    Fix: Replace String() conversion for incognito to preserve boolean type as expected.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
3. src/background/heartbeat.ts:34
  • Draft comment:
    Good fix: using 'tab.audible ?? false' ensures the value is boolean instead of string.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
4. src/background/heartbeat.ts:35
  • Draft comment:
    Properly passing 'tab.incognito' directly (boolean) resolves the string conversion issue.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None

Workflow ID: wflow_yxVB7pfBOlKtXt1A


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@BelKed
Copy link
Contributor Author

BelKed commented Mar 4, 2025

Related PR in aw-client-js:

@ErikBjare ErikBjare merged commit af8450c into ActivityWatch:master Mar 5, 2025
4 of 5 checks passed
@BelKed BelKed deleted the booleans branch March 12, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reported issue with booleans in v0.5.0

2 participants