fix: use boolean for audible and incognito#171
Merged
ErikBjare merged 1 commit intoActivityWatch:masterfrom Mar 5, 2025
Merged
fix: use boolean for audible and incognito#171ErikBjare merged 1 commit intoActivityWatch:masterfrom
audible and incognito#171ErikBjare merged 1 commit intoActivityWatch:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 060ec52 in 31 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. src/background/heartbeat.ts:34
- Draft comment:
Good: Changing audible from string to boolean resolves type issues. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. src/background/heartbeat.ts:35
- Draft comment:
Fix: Replace String() conversion for incognito to preserve boolean type as expected. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. src/background/heartbeat.ts:34
- Draft comment:
Good fix: using 'tab.audible ?? false' ensures the value is boolean instead of string. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
4. src/background/heartbeat.ts:35
- Draft comment:
Properly passing 'tab.incognito' directly (boolean) resolves the string conversion issue. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
Workflow ID: wflow_yxVB7pfBOlKtXt1A
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Contributor
Author
|
Related PR in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Convert
audibleandincognitoproperties to booleans inheartbeat()inheartbeat.ts.audibleandincognitoproperties inheartbeat()from strings to booleans inheartbeat.ts.audibleisundefinedby defaulting tofalse.This description was created by
for 060ec52. It will automatically update as commits are pushed.