Skip to content

fix: use boolean for audible and incognito #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBjare merged 1 commit into from
Mar 5, 2025
Merged

fix: use boolean for audible and incognito #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/background/heartbeat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
const data: IEvent['data'] = {
url: tab.url,
title: tab.title,
audible: String(tab.audible ?? false),
incognito: String(tab.incognito),
audible: tab.audible ?? false,

Check failure on line 34 in src/background/heartbeat.ts

View workflow job for this annotation

GitHub Actions / typecheck 

Type 'boolean' is not assignable to type 'string | number'.
incognito: tab.incognito,

Check failure on line 35 in src/background/heartbeat.ts

View workflow job for this annotation

GitHub Actions / typecheck 

Type 'boolean' is not assignable to type 'string | number'.
tabCount: tabCount,
}
const previousData = await getHeartbeatData()
Expand Down
Loading