[ECP-9487-V9] Handle exceptions in AdyenLogger getInvoiceContext#3221
[ECP-9487-V9] Handle exceptions in AdyenLogger getInvoiceContext#3221shubhamk67 merged 3 commits intomain-9from
Conversation
Summary of ChangesHello @shubhamk67, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the stability and resilience of the AdyenLogger by introducing robust exception handling within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds exception handling to AdyenLogger::getInvoiceContext to ensure that webhook processing can continue even if gathering invoice context for logging fails. While this is a good improvement for robustness, I've noticed that the exception is silently ignored. My review includes a suggestion to log the exception before returning an empty context. This will ensure that potential issues are not hidden, making debugging easier in the future.
| 'invoiceCanRefund' => $invoice->canRefund() | ||
| ]; | ||
| } catch (\Exception $e) { | ||
| return []; |
There was a problem hiding this comment.
While handling the exception is correct to prevent process interruption, swallowing it silently can hide potential issues. It's better to log the exception to be aware of any problems occurring during context retrieval. This will help with debugging in the future without stopping the webhook processing.
$this->addAdyenWarning('Failed to get invoice context: ' . $e->getMessage());
return [];
|
|


Description
This PR adds exception handling in AdyenLogger.getInvoiceContext() to allow webhook processing to continue in case of failures during logging by returning an empty context.