Skip to content

[ECP-9487-V9] Handle exceptions in AdyenLogger getInvoiceContext#3221

Merged
shubhamk67 merged 3 commits intomain-9from
ECP-9487-V9
Jan 16, 2026
Merged

[ECP-9487-V9] Handle exceptions in AdyenLogger getInvoiceContext#3221
shubhamk67 merged 3 commits intomain-9from
ECP-9487-V9

Conversation

@shubhamk67
Copy link
Contributor

Description
This PR adds exception handling in AdyenLogger.getInvoiceContext() to allow webhook processing to continue in case of failures during logging by returning an empty context.

@shubhamk67 shubhamk67 requested a review from a team as a code owner January 12, 2026 09:43
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shubhamk67, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the stability and resilience of the AdyenLogger by introducing robust exception handling within the getInvoiceContext method. The core purpose is to prevent logging-related failures from disrupting critical operations, such as webhook processing. By catching exceptions and providing a fallback (an empty context), the system can maintain continuity and avoid unexpected interruptions, ensuring a more reliable overall workflow.

Highlights

  • Exception Handling: Implemented a try-catch block within the AdyenLogger::getInvoiceContext method to gracefully handle potential errors during invoice context retrieval.
  • Improved Robustness: Ensures that webhook processing can continue uninterrupted even if an exception occurs while attempting to log invoice context, preventing critical process failures.
  • Error Mitigation: When an exception is caught in getInvoiceContext, an empty array is now returned, allowing the calling function to proceed without a complete invoice context, rather than halting due to an unhandled error.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds exception handling to AdyenLogger::getInvoiceContext to ensure that webhook processing can continue even if gathering invoice context for logging fails. While this is a good improvement for robustness, I've noticed that the exception is silently ignored. My review includes a suggestion to log the exception before returning an empty context. This will ensure that potential issues are not hidden, making debugging easier in the future.

'invoiceCanRefund' => $invoice->canRefund()
];
} catch (\Exception $e) {
return [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While handling the exception is correct to prevent process interruption, swallowing it silently can hide potential issues. It's better to log the exception to be aware of any problems occurring during context retrieval. This will help with debugging in the future without stopping the webhook processing.

            $this->addAdyenWarning('Failed to get invoice context: ' . $e->getMessage());
            return [];

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@shubhamk67 shubhamk67 merged commit c6f7f18 into main-9 Jan 16, 2026
9 of 11 checks passed
@shubhamk67 shubhamk67 added the Fix Indicates a bug fix label Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Indicates a bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants