Skip to content

[ECP-9487-V9] Handle exceptions in AdyenLogger getInvoiceContext #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shubhamk67 merged 3 commits into from
Jan 16, 2026
+17 −12
Merged

[ECP-9487-V9] Handle exceptions in AdyenLogger getInvoiceContext #3221

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e83a7f
[ECP-9487] Add exception handling to getInvoiceContext in AdyenLogger
shubhamk67 Jan 12, 2026
78199f7
[ECP-9487] Catch Throwable and log warning
shubhamk67 Jan 12, 2026
07ff8a6
Merge branch 'main-9' into ECP-9487-V9
shubhamk67 Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions Logger/AdyenLogger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,18 +120,22 @@ public function getOrderContext(MagentoOrder $order): array

public function getInvoiceContext(MagentoOrder\Invoice $invoice): array
{
$stateName = $invoice->getStateName();
try {
$stateName = $invoice->getStateName();

return [
'invoiceId' => $invoice->getEntityId(),
'invoiceIncrementId' => $invoice->getIncrementId(),
'invoiceState' => $invoice->getState(),
'invoiceStateName' => $stateName instanceof Phrase ? $stateName->getText() : $stateName,
'invoiceWasPayCalled' => $invoice->wasPayCalled(),
'invoiceCanCapture' => $invoice->canCapture(),
'invoiceCanCancel' => $invoice->canCancel(),
'invoiceCanVoid' => $invoice->canVoid(),
'invoiceCanRefund' => $invoice->canRefund()
];
return [
'invoiceId' => $invoice->getEntityId(),
'invoiceIncrementId' => $invoice->getIncrementId(),
'invoiceState' => $invoice->getState(),
'invoiceStateName' => $stateName instanceof Phrase ? $stateName->getText() : $stateName,
'invoiceWasPayCalled' => $invoice->wasPayCalled(),
'invoiceCanCapture' => $invoice->canCapture(),
'invoiceCanCancel' => $invoice->canCancel(),
'invoiceCanVoid' => $invoice->canVoid(),
'invoiceCanRefund' => $invoice->canRefund()
];
} catch (\Exception $e) {
return [];
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While handling the exception is correct to prevent process interruption, swallowing it silently can hide potential issues. It's better to log the exception to be aware of any problems occurring during context retrieval. This will help with debugging in the future without stopping the webhook processing.

            $this->addAdyenWarning('Failed to get invoice context: ' . $e->getMessage());
            return [];

}
}
}
Loading