Skip to content

[balancecontrol] Code generation: update services and models#852

Merged
gcatanese merged 1 commit intomainfrom
sdk-automation/balancecontrol
Jan 16, 2026
Merged

[balancecontrol] Code generation: update services and models#852
gcatanese merged 1 commit intomainfrom
sdk-automation/balancecontrol

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the balancecontrol service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners January 13, 2026 14:59
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an automated update to the balancecontrol service's PHP models. The primary impact is a shift in how invalid enum values are managed, moving from strict exception-throwing to a more lenient error logging approach. This change aims to improve robustness by preventing application crashes due to unexpected enum values, instead logging them for review.

Highlights

  • Error Handling Update: The handling of invalid enum values has been changed from throwing an InvalidArgumentException to logging an error using error_log.
  • Error Message Formatting: The format of the error messages for invalid enum values has been updated to provide clearer information, specifying 'unexpected enum value' and listing 'Supported values'.
  • Automated Code Generation: These changes are part of an automated update to the balancecontrol service's models and services, reflecting recent adyen-openapi commits.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, although automated, introduces a significant and potentially harmful change in the error handling strategy for model validation. By replacing throw new \InvalidArgumentException with error_log in property setters for enum values, the models now allow invalid data to be set. This moves away from a "fail-fast" approach, where invalid data would immediately cause an exception, to a more lenient "log and continue" approach. This can lead to objects being in an invalid state without the consuming application being aware, potentially causing subtle and hard-to-debug issues. While logging might seem useful for forward compatibility with API responses, it makes the SDK less safe to use, especially for request models. I have added comments to revert these changes to restore the safer exception-throwing behavior.

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balancecontrol branch 2 times, most recently from a474710 to 58508f1 Compare January 16, 2026 08:11
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balancecontrol branch from 58508f1 to b0ce86c Compare January 16, 2026 08:27
@sonarqubecloud
Copy link

@gcatanese gcatanese merged commit 2b907bb into main Jan 16, 2026
9 checks passed
@gcatanese gcatanese deleted the sdk-automation/balancecontrol branch January 16, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants