[balancecontrol] Code generation: update services and models#852
[balancecontrol] Code generation: update services and models#852
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an automated update to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, although automated, introduces a significant and potentially harmful change in the error handling strategy for model validation. By replacing throw new \InvalidArgumentException with error_log in property setters for enum values, the models now allow invalid data to be set. This moves away from a "fail-fast" approach, where invalid data would immediately cause an exception, to a more lenient "log and continue" approach. This can lead to objects being in an invalid state without the consuming application being aware, potentially causing subtle and hard-to-debug issues. While logging might seem useful for forward compatibility with API responses, it makes the SDK less safe to use, especially for request models. I have added comments to revert these changes to restore the safer exception-throwing behavior.
a474710 to
58508f1
Compare
58508f1 to
b0ce86c
Compare
|



This PR contains the automated changes for the
balancecontrolservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.