Skip to content

[managementwebhooks] Code generation: update services and models#856

Merged
gcatanese merged 1 commit intomainfrom
sdk-automation/managementwebhooks
Jan 23, 2026
Merged

[managementwebhooks] Code generation: update services and models#856
gcatanese merged 1 commit intomainfrom
sdk-automation/managementwebhooks

Conversation

@AdyenAutomationBot
Copy link
Collaborator

@AdyenAutomationBot AdyenAutomationBot commented Jan 13, 2026

This PR contains the automated changes for the managementwebhooks service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

Management Webhooks

  • Add attribute assignedToStoreId in TerminalAssignmentNotificationRequest
  • Add enum TYPE_DATA_REVIEW in VerificationError

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners January 13, 2026 14:59
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces updates to the managementwebhooks service models. It adds a new field for terminal assignment and a new verification error type, enhancing the data provided by the service.

Highlights

  • Model Update: The TerminalAssignmentNotificationRequest model has been updated to include a new field assignedToStoreId.
  • Verification Error Types: The VerificationError and VerificationErrorRecursive models now include a new error type dataReview.
  • Documentation Improvement: The description for assignedToStore in TerminalAssignmentNotificationRequest has been updated for clarity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR, generated automatically, updates services and models for managementwebhooks. The changes include adding a new assignedToStoreId property to TerminalAssignmentNotificationRequest, introducing a new TYPE_DATA_REVIEW constant in VerificationError and VerificationErrorRecursive models, and updating some documentation.

My review focuses on ensuring consistency and correctness in the generated models. I've pointed out a few areas for improvement:

  • There's an inconsistency in the nullability definition for the new assignedToStoreId property in TerminalAssignmentNotificationRequest.
  • The PHPDoc comments for setType in VerificationError and VerificationErrorRecursive are outdated and don't include the newly added TYPE_DATA_REVIEW value.

These are likely issues with the code generator or the underlying OpenAPI specification, and addressing them will improve the robustness and maintainability of the models.

protected static $openAPINullables = [
'assignedToAccount' => false,
'assignedToStore' => false,
'assignedToStoreId' => false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's an inconsistency for the assignedToStoreId property. It's marked as non-nullable here (false), but the getter/setter methods allow null values (docblock string|null), and listInvalidProperties doesn't validate against null. This could lead to an invalid model state being considered valid.

If assignedToStoreId is required and not nullable, it should be checked for null in listInvalidProperties. If it's nullable, this value should be true.

This seems to follow a pattern already present for assignedToStore, which has the same inconsistency. It would be good to clarify the nullability and requirement constraints for both properties.

}

public const TYPE_DATA_MISSING = 'dataMissing';
public const TYPE_DATA_REVIEW = 'dataReview';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With the addition of the new TYPE_DATA_REVIEW constant, the PHPDoc for the setType method on line 440 has become outdated. Please update it to include dataReview in the list of possible values to ensure documentation stays in sync with the code.

}

public const TYPE_DATA_MISSING = 'dataMissing';
public const TYPE_DATA_REVIEW = 'dataReview';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With the addition of the new TYPE_DATA_REVIEW constant, the PHPDoc for the setType method on line 385 has become outdated. Please update it to include dataReview in the list of possible values to ensure documentation stays in sync with the code.

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/managementwebhooks branch 4 times, most recently from f7074f3 to 9ac06e6 Compare January 16, 2026 12:55
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/managementwebhooks branch from 9ac06e6 to 5fdced8 Compare January 22, 2026 18:49
@sonarqubecloud
Copy link

@gcatanese gcatanese added this pull request to the merge queue Jan 23, 2026
Merged via the queue into main with commit 0544417 Jan 23, 2026
9 checks passed
@gcatanese gcatanese deleted the sdk-automation/managementwebhooks branch January 23, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants