[managementwebhooks] Code generation: update services and models#856
[managementwebhooks] Code generation: update services and models#856
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces updates to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR, generated automatically, updates services and models for managementwebhooks. The changes include adding a new assignedToStoreId property to TerminalAssignmentNotificationRequest, introducing a new TYPE_DATA_REVIEW constant in VerificationError and VerificationErrorRecursive models, and updating some documentation.
My review focuses on ensuring consistency and correctness in the generated models. I've pointed out a few areas for improvement:
- There's an inconsistency in the nullability definition for the new
assignedToStoreIdproperty inTerminalAssignmentNotificationRequest. - The PHPDoc comments for
setTypeinVerificationErrorandVerificationErrorRecursiveare outdated and don't include the newly addedTYPE_DATA_REVIEWvalue.
These are likely issues with the code generator or the underlying OpenAPI specification, and addressing them will improve the robustness and maintainability of the models.
| protected static $openAPINullables = [ | ||
| 'assignedToAccount' => false, | ||
| 'assignedToStore' => false, | ||
| 'assignedToStoreId' => false, |
There was a problem hiding this comment.
There's an inconsistency for the assignedToStoreId property. It's marked as non-nullable here (false), but the getter/setter methods allow null values (docblock string|null), and listInvalidProperties doesn't validate against null. This could lead to an invalid model state being considered valid.
If assignedToStoreId is required and not nullable, it should be checked for null in listInvalidProperties. If it's nullable, this value should be true.
This seems to follow a pattern already present for assignedToStore, which has the same inconsistency. It would be good to clarify the nullability and requirement constraints for both properties.
| } | ||
|
|
||
| public const TYPE_DATA_MISSING = 'dataMissing'; | ||
| public const TYPE_DATA_REVIEW = 'dataReview'; |
| } | ||
|
|
||
| public const TYPE_DATA_MISSING = 'dataMissing'; | ||
| public const TYPE_DATA_REVIEW = 'dataReview'; |
f7074f3 to
9ac06e6
Compare
9ac06e6 to
5fdced8
Compare
|



This PR contains the automated changes for the
managementwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.Management Webhooks
assignedToStoreIdinTerminalAssignmentNotificationRequestTYPE_DATA_REVIEWinVerificationError