Skip to content

[configurationwebhooks] Code generation: update services and models #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcatanese merged 1 commit into from
Jan 23, 2026
Merged

[configurationwebhooks] Code generation: update services and models #861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Adyen/Model/ConfigurationWebhooks/Amount.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ public function getCurrency()
/**
* Sets currency
*
* @param string $currency The three-character [ISO currency code](https://docs.adyen.com/development-resources/currency-codes#currency-codes).
* @param string $currency The three-character [ISO currency code](https://docs.adyen.com/development-resources/currency-codes#currency-codes) of the amount.
*
* @return self
*/
Expand All @@ -323,7 +323,7 @@ public function getValue()
/**
* Sets value
*
* @param int $value The amount of the transaction, in [minor units](https://docs.adyen.com/development-resources/currency-codes#minor-units).
* @param int $value The numeric value of the amount, in [minor units](https://docs.adyen.com/development-resources/currency-codes#minor-units).
*
* @return self
*/
Expand Down
124 changes: 124 additions & 0 deletions src/Adyen/Model/ConfigurationWebhooks/BulkAddress.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@ class BulkAddress implements ModelInterface, ArrayAccess, \JsonSerializable
'country' => 'string',
'email' => 'string',
'houseNumberOrName' => 'string',
'line1' => 'string',
'line2' => 'string',
'line3' => 'string',
'mobile' => 'string',
'name' => 'string',
'postalCode' => 'string',
'stateOrProvince' => 'string',
'street' => 'string'
Expand All @@ -65,7 +69,11 @@ class BulkAddress implements ModelInterface, ArrayAccess, \JsonSerializable
'country' => null,
'email' => null,
'houseNumberOrName' => null,
'line1' => null,
'line2' => null,
'line3' => null,
'mobile' => null,
'name' => null,
'postalCode' => null,
'stateOrProvince' => null,
'street' => null
Expand All @@ -82,7 +90,11 @@ class BulkAddress implements ModelInterface, ArrayAccess, \JsonSerializable
'country' => false,
'email' => false,
'houseNumberOrName' => false,
'line1' => false,
'line2' => false,
'line3' => false,
'mobile' => false,
'name' => false,
Comment on lines +93 to +97
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new properties line1, line2, line3, and name are defined as nullable in their setters (accepting string|null), but are marked as non-nullable here by being set to false. This prevents them from being explicitly serialized as null in a JSON payload. To ensure consistency and allow for explicit nulling of these fields, their values in the $openAPINullables array should be true.

        'line1' => true,
        'line2' => true,
        'line3' => true,
        'mobile' => false,
        'name' => true,

'postalCode' => false,
'stateOrProvince' => false,
'street' => false
Expand Down Expand Up @@ -179,7 +191,11 @@ public function isNullableSetToNull(string $property): bool
'country' => 'country',
'email' => 'email',
'houseNumberOrName' => 'houseNumberOrName',
'line1' => 'line1',
'line2' => 'line2',
'line3' => 'line3',
'mobile' => 'mobile',
'name' => 'name',
'postalCode' => 'postalCode',
'stateOrProvince' => 'stateOrProvince',
'street' => 'street'
Expand All @@ -196,7 +212,11 @@ public function isNullableSetToNull(string $property): bool
'country' => 'setCountry',
'email' => 'setEmail',
'houseNumberOrName' => 'setHouseNumberOrName',
'line1' => 'setLine1',
'line2' => 'setLine2',
'line3' => 'setLine3',
'mobile' => 'setMobile',
'name' => 'setName',
'postalCode' => 'setPostalCode',
'stateOrProvince' => 'setStateOrProvince',
'street' => 'setStreet'
Expand All @@ -213,7 +233,11 @@ public function isNullableSetToNull(string $property): bool
'country' => 'getCountry',
'email' => 'getEmail',
'houseNumberOrName' => 'getHouseNumberOrName',
'line1' => 'getLine1',
'line2' => 'getLine2',
'line3' => 'getLine3',
'mobile' => 'getMobile',
'name' => 'getName',
'postalCode' => 'getPostalCode',
'stateOrProvince' => 'getStateOrProvince',
'street' => 'getStreet'
Expand Down Expand Up @@ -281,7 +305,11 @@ public function __construct(?array $data = null)
$this->setIfExists('country', $data ?? [], null);
$this->setIfExists('email', $data ?? [], null);
$this->setIfExists('houseNumberOrName', $data ?? [], null);
$this->setIfExists('line1', $data ?? [], null);
$this->setIfExists('line2', $data ?? [], null);
$this->setIfExists('line3', $data ?? [], null);
$this->setIfExists('mobile', $data ?? [], null);
$this->setIfExists('name', $data ?? [], null);
$this->setIfExists('postalCode', $data ?? [], null);
$this->setIfExists('stateOrProvince', $data ?? [], null);
$this->setIfExists('street', $data ?? [], null);
Expand Down Expand Up @@ -452,6 +480,78 @@ public function setHouseNumberOrName($houseNumberOrName)
return $this;
}

/**
* Gets line1
*
* @return string|null
*/
public function getLine1()
{
return $this->container['line1'];
}

/**
* Sets line1
*
* @param string|null $line1 The name of the street and the number of the building. For example: **Simon Carmiggeltstraat 6-50**.
*
* @return self
*/
public function setLine1($line1)
{
$this->container['line1'] = $line1;

return $this;
}

/**
* Gets line2
*
* @return string|null
*/
public function getLine2()
{
return $this->container['line2'];
}

/**
* Sets line2
*
* @param string|null $line2 Additional information about the delivery address. For example, an apartment number.
*
* @return self
*/
public function setLine2($line2)
{
$this->container['line2'] = $line2;

return $this;
}

/**
* Gets line3
*
* @return string|null
*/
public function getLine3()
{
return $this->container['line3'];
}

/**
* Sets line3
*
* @param string|null $line3 Additional information about the delivery address.
*
* @return self
*/
public function setLine3($line3)
{
$this->container['line3'] = $line3;

return $this;
}

/**
* Gets mobile
*
Expand All @@ -476,6 +576,30 @@ public function setMobile($mobile)
return $this;
}

/**
* Gets name
*
* @return string|null
*/
public function getName()
{
return $this->container['name'];
}

/**
* Sets name
*
* @param string|null $name The recipient’s name (person or contact), for example ‘John Doe’.
*
* @return self
*/
public function setName($name)
{
$this->container['name'] = $name;

return $this;
}

/**
* Gets postalCode
*
Expand Down
7 changes: 2 additions & 5 deletions src/Adyen/Model/ConfigurationWebhooks/Card.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,9 +386,6 @@ public function listInvalidProperties()
);
}

if ($this->container['number'] === null) {
$invalidProperties[] = "'number' can't be null";
}
return $invalidProperties;
}

Expand Down Expand Up @@ -681,7 +678,7 @@ public function setLastFour($lastFour)
/**
* Gets number
*
* @return string
* @return string|null
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the return type for getNumber() is correctly updated to be nullable, the model's metadata for this property seems inconsistent. In the $openAPINullables array, 'number' is still set to false. This prevents the property from being explicitly serialized as null. To fully support nullability, $openAPINullables['number'] should be set to true. Please check if this was an oversight.

*/
public function getNumber()
{
Expand All @@ -691,7 +688,7 @@ public function getNumber()
/**
* Sets number
*
* @param string $number The primary account number (PAN) of the card. > The PAN is masked by default and returned only for single-use virtual cards.
* @param string|null $number The primary account number (PAN) of the card. > The PAN is masked by default and returned only for single-use virtual cards.
*
* @return self
*/
Expand Down
22 changes: 11 additions & 11 deletions src/Adyen/Model/ConfigurationWebhooks/CardConfiguration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ public function getActivation()
/**
* Sets activation
*
* @param string|null $activation Overrides the activation label design ID defined in the `configurationProfileId`. The activation label is attached to the card and contains the activation instructions.
* @param string|null $activation The activation label attached to the card that contains the activation instructions. This field overrides the activation label design ID defined in the card configuration profile.
*
* @return self
*/
Expand Down Expand Up @@ -452,7 +452,7 @@ public function getCardImageId()
/**
* Sets cardImageId
*
* @param string|null $cardImageId The ID of the card image. This is the image that will be printed on the full front of the card.
* @param string|null $cardImageId The unique identifier of the card image. This image is printed on the full front of the card.
*
* @return self
*/
Expand All @@ -476,7 +476,7 @@ public function getCarrier()
/**
* Sets carrier
*
* @param string|null $carrier Overrides the carrier design ID defined in the `configurationProfileId`. The carrier is the letter or packaging to which the card is attached.
* @param string|null $carrier The letter or packaging to which the card is attached. This field overrides the carrier design ID defined in the card configuration profile.
*
* @return self
*/
Expand All @@ -500,7 +500,7 @@ public function getCarrierImageId()
/**
* Sets carrierImageId
*
* @param string|null $carrierImageId The ID of the carrier image. This is the image that will printed on the letter to which the card is attached.
* @param string|null $carrierImageId The unique identifier of the carrier image. This image is printed on the letter to which the card is attached.
*
* @return self
*/
Expand All @@ -524,7 +524,7 @@ public function getConfigurationProfileId()
/**
* Sets configurationProfileId
*
* @param string $configurationProfileId The ID of the card configuration profile that contains the settings of the card. For example, the envelope and PIN mailer designs or the logistics company handling the shipment. All the settings in the profile are applied to the card, unless you provide other fields to override them. For example, send the `shipmentMethod` to override the logistics company defined in the card configuration profile.
* @param string $configurationProfileId The unique identifier of the card configuration profile that contains the settings that are applied to the card. For example, the envelope and PIN mailer designs or the logistics company handling the shipment. You can override some of the existing settings in the configuration profile by providing the corresponding fields in the `configuration` object. For example, send the `shipmentMethod` to override the logistics company defined in the card configuration profile.
*
* @return self
*/
Expand All @@ -548,7 +548,7 @@ public function getCurrency()
/**
* Sets currency
*
* @param string|null $currency The three-letter [ISO-4217](https://en.wikipedia.org/wiki/ISO_4217) currency code of the card. For example, **EUR**.
* @param string|null $currency The three-letter [ISO-4217](https://en.wikipedia.org/wiki/ISO_4217) currency code of the card. For example, **EUR**. This field overrides the existing currency setting on the card configuration profile.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This property is documented as nullable, but its corresponding entry in the $openAPINullables array is false. This is true for other nullable properties in this file as well (e.g., activation, cardImageId). This inconsistency prevents these properties from being explicitly serialized as null. To ensure correct behavior, all nullable properties should be marked as true in the $openAPINullables array.

*
* @return self
*/
Expand All @@ -572,7 +572,7 @@ public function getEnvelope()
/**
* Sets envelope
*
* @param string|null $envelope Overrides the envelope design ID defined in the `configurationProfileId`.
* @param string|null $envelope Overrides the envelope design ID defined in the card configuration profile.
*
* @return self
*/
Expand All @@ -596,7 +596,7 @@ public function getInsert()
/**
* Sets insert
*
* @param string|null $insert Overrides the insert design ID defined in the `configurationProfileId`. An insert is any additional material, such as marketing materials, that are shipped together with the card.
* @param string|null $insert Any additional material, such as marketing material, that is shipped together with the card. This field overrides the insert design ID defined in the card configuration profile.
*
* @return self
*/
Expand Down Expand Up @@ -644,7 +644,7 @@ public function getLogoImageId()
/**
* Sets logoImageId
*
* @param string|null $logoImageId The ID of the logo image. This is the image that will be printed on the partial front of the card, such as a logo on the upper right corner.
* @param string|null $logoImageId The unique identifier of the logo image. This image is printed on the partial front of the card, for example, a logo on the upper right corner.
*
* @return self
*/
Expand All @@ -668,7 +668,7 @@ public function getPinMailer()
/**
* Sets pinMailer
*
* @param string|null $pinMailer Overrides the PIN mailer design ID defined in the `configurationProfileId`. The PIN mailer is the letter on which the PIN is printed.
* @param string|null $pinMailer The letter on which the PIN of the card is printed. This field overrides the PIN mailer design ID defined in the card configuration profile.
*
* @return self
*/
Expand All @@ -692,7 +692,7 @@ public function getShipmentMethod()
/**
* Sets shipmentMethod
*
* @param string|null $shipmentMethod Overrides the logistics company defined in the `configurationProfileId`.
* @param string|null $shipmentMethod The logistics company that ships the card. This field overrides the logistics company defined in the card configuration profile.
*
* @return self
*/
Expand Down
Loading