[configurationwebhooks] Code generation: update services and models#861
[configurationwebhooks] Code generation: update services and models#861
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers automated updates to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request appears to be auto-generated, updating models and services for configurationwebhooks. The changes primarily involve adding new properties to several models and updating documentation. My review focuses on a recurring inconsistency in the generated code related to property nullability. Several properties are documented as nullable in their setters and getters, but are marked as non-nullable in the model's $openAPINullables metadata. This can lead to incorrect serialization behavior, specifically preventing explicit null values from being sent. I've added comments with suggestions to fix this for the affected models.
| 'line1' => false, | ||
| 'line2' => false, | ||
| 'line3' => false, | ||
| 'mobile' => false, | ||
| 'name' => false, |
There was a problem hiding this comment.
The new properties line1, line2, line3, and name are defined as nullable in their setters (accepting string|null), but are marked as non-nullable here by being set to false. This prevents them from being explicitly serialized as null in a JSON payload. To ensure consistency and allow for explicit nulling of these fields, their values in the $openAPINullables array should be true.
'line1' => true,
'line2' => true,
'line3' => true,
'mobile' => false,
'name' => true,| * Gets number | ||
| * | ||
| * @return string | ||
| * @return string|null |
There was a problem hiding this comment.
While the return type for getNumber() is correctly updated to be nullable, the model's metadata for this property seems inconsistent. In the $openAPINullables array, 'number' is still set to false. This prevents the property from being explicitly serialized as null. To fully support nullability, $openAPINullables['number'] should be set to true. Please check if this was an oversight.
| * Sets currency | ||
| * | ||
| * @param string|null $currency The three-letter [ISO-4217](https://en.wikipedia.org/wiki/ISO_4217) currency code of the card. For example, **EUR**. | ||
| * @param string|null $currency The three-letter [ISO-4217](https://en.wikipedia.org/wiki/ISO_4217) currency code of the card. For example, **EUR**. This field overrides the existing currency setting on the card configuration profile. |
There was a problem hiding this comment.
This property is documented as nullable, but its corresponding entry in the $openAPINullables array is false. This is true for other nullable properties in this file as well (e.g., activation, cardImageId). This inconsistency prevents these properties from being explicitly serialized as null. To ensure correct behavior, all nullable properties should be marked as true in the $openAPINullables array.
| * @var boolean[] | ||
| */ | ||
| protected static $openAPINullables = [ | ||
| 'deviceId' => false, |
| 'decision' => false, | ||
| 'id' => false, | ||
| 'paymentInstrumentId' => false, | ||
| 'schemeRiskScore' => false, |
10a3710 to
419c49e
Compare
419c49e to
a975a7a
Compare
a975a7a to
91aaca6
Compare
|



This PR contains the automated changes for the
configurationwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.Configuration Webhooks
BulkAddressadd attributesline1,line2,line3,mobile,namenumberinCarddeviceIdinDeviceschemeRiskScoreinNetworkTokenNotificationDataV2.phpTYPE_DATA_REVIEWinVerificationErrorTYPE_DATA_REVIEWinVerificationErrorRecursiveNote
In
SweepConfigurationV2several enum values have been deleted (REASON_APPROVAL_EXPIRED,REASON_DECLINED, etc..), however those values were never delivered or used.