Skip to content

[configurationwebhooks] Code generation: update services and models#861

Merged
gcatanese merged 1 commit intomainfrom
sdk-automation/configurationwebhooks
Jan 23, 2026
Merged

[configurationwebhooks] Code generation: update services and models#861
gcatanese merged 1 commit intomainfrom
sdk-automation/configurationwebhooks

Conversation

@AdyenAutomationBot
Copy link
Collaborator

@AdyenAutomationBot AdyenAutomationBot commented Jan 13, 2026

This PR contains the automated changes for the configurationwebhooks service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

Configuration Webhooks

  • In BulkAddress add attributes line1, line2, line3, mobile, name
  • Make optional attribute number in Card
  • Add attribute deviceId in Device
  • Add attribute schemeRiskScore in NetworkTokenNotificationDataV2.php
  • Add enum value TYPE_DATA_REVIEW in VerificationError
  • Add enum value TYPE_DATA_REVIEW in VerificationErrorRecursive

Note

In SweepConfigurationV2 several enum values have been deleted (REASON_APPROVAL_EXPIRED, REASON_DECLINED, etc..), however those values were never delivered or used.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners January 13, 2026 14:59
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers automated updates to the configurationwebhooks service, primarily focusing on enriching existing data models and enhancing documentation. The changes introduce new attributes to better represent address and device information, adjust field constraints for increased flexibility, and clarify the usage of various configuration settings through updated Javadoc comments. These updates ensure the service models remain aligned with the latest API specifications and improve overall code readability.

Highlights

  • Model Enhancements: New fields have been added to several models, including line1, line2, line3, and name to BulkAddress, and deviceId to Device. The NetworkTokenNotificationDataV2 model now includes a schemeRiskScore field.
  • Field Nullability: The number field in the Card model has been updated to be nullable, removing a previous restriction that required its presence.
  • Javadoc Clarifications: Numerous Javadoc comments across various models, such as Amount and CardConfiguration, have been refined for improved clarity and to provide more detailed explanations of field purposes and override behaviors.
  • New Constants: New constants have been introduced, including REASON_SCHEME_ADVICE in SweepConfigurationV2 and TYPE_DATA_REVIEW in VerificationError and VerificationErrorRecursive models, expanding the possible values for certain enumeration fields.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be auto-generated, updating models and services for configurationwebhooks. The changes primarily involve adding new properties to several models and updating documentation. My review focuses on a recurring inconsistency in the generated code related to property nullability. Several properties are documented as nullable in their setters and getters, but are marked as non-nullable in the model's $openAPINullables metadata. This can lead to incorrect serialization behavior, specifically preventing explicit null values from being sent. I've added comments with suggestions to fix this for the affected models.

Comment on lines +93 to +97
'line1' => false,
'line2' => false,
'line3' => false,
'mobile' => false,
'name' => false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new properties line1, line2, line3, and name are defined as nullable in their setters (accepting string|null), but are marked as non-nullable here by being set to false. This prevents them from being explicitly serialized as null in a JSON payload. To ensure consistency and allow for explicit nulling of these fields, their values in the $openAPINullables array should be true.

        'line1' => true,
        'line2' => true,
        'line3' => true,
        'mobile' => false,
        'name' => true,

* Gets number
*
* @return string
* @return string|null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the return type for getNumber() is correctly updated to be nullable, the model's metadata for this property seems inconsistent. In the $openAPINullables array, 'number' is still set to false. This prevents the property from being explicitly serialized as null. To fully support nullability, $openAPINullables['number'] should be set to true. Please check if this was an oversight.

* Sets currency
*
* @param string|null $currency The three-letter [ISO-4217](https://en.wikipedia.org/wiki/ISO_4217) currency code of the card. For example, **EUR**.
* @param string|null $currency The three-letter [ISO-4217](https://en.wikipedia.org/wiki/ISO_4217) currency code of the card. For example, **EUR**. This field overrides the existing currency setting on the card configuration profile.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This property is documented as nullable, but its corresponding entry in the $openAPINullables array is false. This is true for other nullable properties in this file as well (e.g., activation, cardImageId). This inconsistency prevents these properties from being explicitly serialized as null. To ensure correct behavior, all nullable properties should be marked as true in the $openAPINullables array.

* @var boolean[]
*/
protected static $openAPINullables = [
'deviceId' => false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new property deviceId is defined as nullable in its setter (accepting string|null), but is marked as non-nullable here. To allow this field to be explicitly serialized as null in a JSON payload, its value should be true.

        'deviceId' => true,

'decision' => false,
'id' => false,
'paymentInstrumentId' => false,
'schemeRiskScore' => false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new property schemeRiskScore is defined as nullable in its setter (accepting string|null), but is marked as non-nullable here. To allow this field to be explicitly serialized as null in a JSON payload, its value should be true.

        'schemeRiskScore' => true,

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/configurationwebhooks branch 4 times, most recently from 10a3710 to 419c49e Compare January 16, 2026 12:55
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/configurationwebhooks branch from 419c49e to a975a7a Compare January 21, 2026 13:28
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/configurationwebhooks branch from a975a7a to 91aaca6 Compare January 22, 2026 18:49
@sonarqubecloud
Copy link

@gcatanese gcatanese added this pull request to the merge queue Jan 23, 2026
Merged via the queue into main with commit 8a04ca3 Jan 23, 2026
9 checks passed
@gcatanese gcatanese deleted the sdk-automation/configurationwebhooks branch January 23, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants