[balancewebhooks] Code generation: update services and models#867
[balancewebhooks] Code generation: update services and models#867
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates updated service and model definitions for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new models for balance webhooks, specifically for Amount, ReleaseBlockedBalanceNotificationData, ReleasedBlockedBalanceNotificationRequest, and ResourceReference. The changes are automatically generated by OpenAPI Generator. The code generally follows good practices for generated models, including serialization and deserialization logic. One area for improvement is the consistency of error handling for enum validation.
| { | ||
| $allowedValues = $this->getTypeAllowableValues(); | ||
| if (!in_array($type, $allowedValues, true)) { | ||
| error_log( | ||
| sprintf( | ||
| "type: unexpected enum value '%s' - Supported values are [%s]", | ||
| $type, | ||
| implode(', ', $allowedValues) | ||
| ) | ||
| ); | ||
| } |
There was a problem hiding this comment.
The setType method uses error_log to report an invalid enum value. For consistency with the ObjectSerializer::deserialize method and to provide more explicit error handling, it would be better to throw an InvalidArgumentException here. This ensures that invalid input is immediately flagged and can be caught by the calling code, preventing potential silent failures or unexpected behavior.
Consider changing this to throw an InvalidArgumentException.
if (!in_array($type, $allowedValues, true)) {
throw new \InvalidArgumentException(
sprintf(
"Invalid value for 'type', must be one of '%s'",
implode("', '", $allowedValues)
)
);
}
$this->container['type'] = $type;
AdyenAutomationBot
force-pushed
the
sdk-automation/balancewebhooks
branch
3 times, most recently
from
9d574f1 to
edffc70
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/balancewebhooks
branch
from
edffc70 to
5a0e189
Compare
|
2 participants
This PR contains the automated changes for the
balancewebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.Balance Webhooks